Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GameServerSet scheduling when Fleet scheduling is changed. #582

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Update GameServerSet scheduling when Fleet scheduling is changed. #582

merged 2 commits into from
Feb 21, 2019

Conversation

pooneh-m
Copy link
Contributor

Fixing issue #495

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5dd65dfe-26e3-4520-883e-2e5f7a16e62d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-770a734

@jkowalski
Copy link
Contributor

very nice, can you also add e2e test?

@markmandel markmandel added kind/bug These are bugs. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 12, 2019
@pooneh-m pooneh-m force-pushed the dev branch 2 times, most recently from 7edc9d3 to 24b32af Compare February 12, 2019 22:12
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 02bfd7e7-4017-4182-8c94-025a44c259b6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b6355aa5-7127-4ea3-b862-375378cee81d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-7edc9d3

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7984a22b-7cfc-4819-aedf-cb9f12d73761

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-84c0a08

@pooneh-m
Copy link
Contributor Author

very nice, can you also add e2e test?

Done! :)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5b7ad804-470d-47f0-a751-1f8483b6f5bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-67c0faf

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b04b992d-c17a-4934-858e-19d3de424130

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-9aabf2a

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Feb 13, 2019
RazvyBD
RazvyBD reviewed Feb 13, 2019
View reviewed changes
Copy link

@RazvyBD RazvyBD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi everyone

@markmandel
Copy link
Member

This is technically a bug, and could be merged during feature freeze, but I'm thinking we leave this until next release, just to give the current code some time to be tested by our users.

Happy to take dissenting opinions.

@markmandel markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 21, 2019
markmandel
markmandel approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@markmandel markmandel added this to the 0.9.0 milestone Feb 21, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cf36dab4-5aff-4879-9650-c658bf35080a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-b0825b3

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: aca283c4-4a5a-47d3-a2cd-568621c1344c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-9b93a78

@markmandel markmandel merged commit 861771b into googleforgames:master Feb 21, 2019
@markmandel markmandel mentioned this pull request Feb 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvyBD RazvyBD RazvyBD left review comments

@aLekSer aLekSer aLekSer left review comments

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pooneh-m @agones-bot @jkowalski @markmandel @aLekSer @RazvyBD