Remove the mutex usage for Delete GS in both GS and GSS controllers #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: b3f0b98b-5ccc-48cf-a5d2-38d57a466aac The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: f39896b7-16b7-4d0c-91fd-21f961c60f53 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
jkowalski
reviewed
Feb 7, 2019
|
Build Succeeded 👏 Build Id: 30d564ee-2ef5-4d05-a61d-9ba0ebe67402 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
We need to squash all commits into one, but otherwise LGTM. |
ilkercelikyilmaz
force-pushed
the
Remove_Allocation_Mutex_From_Delete_GS
branch
from
5daf2b6 to
78412ad
Compare
|
Build Succeeded 👏 Build Id: 1d1ca6d4-1f9b-49cc-95ee-4a4e59092b4f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
approved these changes
Feb 7, 2019
markmandel
added
the
area/performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllocationMutex usage is unnecessary for Delete GS since the Shutdown state of GS prevents race conditions. Also remove direct Delete of GS and change it with setting the status of GS to Shutdown and let the GS controller to take care of it.