Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stackdriver distribution without bucket bounds #554

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Fix stackdriver distribution without bucket bounds #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/metrics/kubernetes_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func init() {
Name: "k8s_client_cache_list_items",
Measure: cacheListItemCountStats,
Description: "Count of items in a list from the Kubernetes API.",
Aggregation: view.Distribution(),
Aggregation: view.Distribution(0),
}))

runtime.Must(view.Register(&view.View{
Expand All @@ -107,14 +107,14 @@ func init() {
Name: "k8s_client_cache_watch_duration_seconds",
Measure: cacheWatchesLatencyStats,
Description: "Duration of watches on the Kubernetes API.",
Aggregation: view.Distribution(),
Aggregation: view.Distribution(0),
}))

runtime.Must(view.Register(&view.View{
Name: "k8s_client_cache_watch_events",
Measure: cacheItemsInWatchesCountStats,
Description: "Number of items in watches on the Kubernetes API.",
Aggregation: view.Distribution(),
Aggregation: view.Distribution(0),
}))

runtime.Must(view.Register(&view.View{
Expand Down Expand Up @@ -144,15 +144,15 @@ func init() {
Name: "k8s_client_workqueue_latency_seconds",
Measure: workQueueLatencyStats,
Description: "How long an item stays in the work queue.",
Aggregation: view.Distribution(),
Aggregation: view.Distribution(0),
TagKeys: []tag.Key{keyQueueName},
}))

runtime.Must(view.Register(&view.View{
Name: "k8s_client_workqueue_work_duration_seconds",
Measure: workQueueWorkDurationStats,
Description: "How long processing an item from the work queue takes.",
Aggregation: view.Distribution(),
Aggregation: view.Distribution(0),
TagKeys: []tag.Key{keyQueueName},
}))

Expand Down
2 changes: 1 addition & 1 deletion site/content/en/docs/Guides/access-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: >
Installing Agones creates several [Custom Resource Definitions (CRD)](https://kubernetes.io/docs/concepts/api-extension/custom-resources),
which can be accessed and manipulated through the Kubernetes API.

Kubernetes has multiple [client libraries](https://kubernetes.io/docs/reference/client-libraries/), however,
Kubernetes has multiple [client libraries](https://kubernetes.io/docs/reference/using-api/client-libraries/), however,
at time of writing, only
the [Go](https://github.com/kubernetes/client-go) and
[Python](https://github.com/kubernetes-client/python/) clients are documented to support accessing CRDs.
Expand Down