New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds gameservers per node count and distribution #551

Merged

cyriltovena merged 1 commit into googleforgames:master from cyriltovena:monitoring/nodes

Feb 4, 2019

Collaborator

cyriltovena commented Feb 1, 2019

Addresses #547

I've included gameservers per nodes (count and distribution) in our Agones GameServers dashboard and move everything related to allocations to Agones Allocations.

Collaborator

agones-bot commented Feb 1, 2019

Build Succeeded 👏

Build Id: 7a47ff10-dfa9-42a4-a3d0-87b2614ffca0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-8e8383b
image: gcr.io/agones-images/agones-sdk:0.8.0-8e8383b
image: gcr.io/agones-images/agones-ping:0.8.0-8e8383b
Linux C++ SDK (build: dev): agonessdk-0.8.0-8e8383b-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-8e8383b-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-8e8383b-src.zip
SDK Server: agonessdk-server-0.8.0-8e8383b.zip

A preview of the website will exist for the next 30 days:

https://8e8383b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/551/head:pr_551 && git checkout pr_551
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-8e8383b

jkowalski reviewed

View reviewed changes

pkg/metrics/controller.go Outdated

+              		nodesCountStats.M(int64(len(gsPerNodes))))
+              	for _, node := range nodes {
+              		if c, ok := gsPerNodes[node.Name]; ok {

Contributor

jkowalski Feb 2, 2019

nit: can be simplified to unconditional

stats.Record(context.Background(), gsPerNodesCountStats.M(gsPerNodes[node.Name]))

because default value in a map is going to be zero.

Collaborator Author

cyriltovena Feb 4, 2019

Interesting you found a bug here ! I was counting more than required, when I made the change metrics were different and correct.

jkowalski reviewed

View reviewed changes

pkg/metrics/controller_metrics.go Show resolved Hide resolved

jkowalski approved these changes

View reviewed changes

Contributor

jkowalski left a comment

only minor comment, feel free to merge when ready

cyriltovena force-pushed the monitoring/nodes branch from 8e8383b to 6fd7e3d Compare

February 3, 2019 18:29

Collaborator

agones-bot commented Feb 3, 2019

Build Failed 😱

Build Id: b0d31dad-0a0d-4b55-8581-c7cca0caae63

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Collaborator

agones-bot commented Feb 3, 2019

Build Failed 😱

Build Id: e1677f87-4373-49e3-a022-20a4827f18dc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

cyriltovena force-pushed the monitoring/nodes branch from 37fbb3b to 697f43c Compare

February 4, 2019 13:00

Collaborator

agones-bot commented Feb 4, 2019

Build Failed 😱

Build Id: f011461b-f3f3-4540-ae9e-6a94cad1147c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.


          Adds gameservers per node count and distribution

5022b65

cyriltovena force-pushed the monitoring/nodes branch from 697f43c to 5022b65 Compare

February 4, 2019 13:58

Collaborator

agones-bot commented Feb 4, 2019

Build Failed 😱

Build Id: b60b7354-524d-4d10-b90f-b4b1a8c0e231

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Collaborator

agones-bot commented Feb 4, 2019

Build Failed 😱

Build Id: b961c74d-07a8-4c80-ae13-43e2df3de736

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Collaborator Author

cyriltovena commented Feb 4, 2019 •

edited

Loading

@jkowalski you fixed this no ?

Step #5 - "tests": --- FAIL: TestControllerSyncFleetAutoscaler (0.03s)
Step #5 - "tests":     --- PASS: TestControllerSyncFleetAutoscaler/fleet_not_available (0.19s)
Step #5 - "tests":     --- FAIL: TestControllerSyncFleetAutoscaler/scaling_down (1.13s)
Step #5 - "tests":         <autogenerated>:1: 
Step #5 - "tests":             	Error Trace:	controller_test.go:221
Step #5 - "tests":             	Error:      	Should be true
Step #5 - "tests":             	Test:       	TestControllerSyncFleetAutoscaler/scaling_down
Step #5 - "tests":             	Messages:   	fleet should have been updated
Step #5 - "tests":         <autogenerated>:1: 
Step #5 - "tests":             	Error Trace:	controller_test.go:222
Step #5 - "tests":             	Error:      	Should be true
Step #5 - "tests":             	Test:       	TestControllerSyncFleetAutoscaler/scaling_down
Step #5 - "tests":             	Messages:   	fleetautoscaler should have been updated
Step #5 - "tests":         <autogenerated>:1: 
Step #5 - "tests":             	Error Trace:	controller.go:95
Step #5 - "tests":             	            				controller_test.go:223
Step #5 - "tests":             	Error:      	"Warning FailedGetFleet could not fetch fleet: fleet-1" does not contain "AutoScalingFleet"
Step #5 - "tests":             	Test:       	TestControllerSyncFleetAutoscaler/scaling_down

Still flaky it just passed without changes

Collaborator

agones-bot commented Feb 4, 2019

Build Succeeded 👏

Build Id: 23207d69-5fc1-4306-851a-cf13cb65e6ee

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-5022b65
image: gcr.io/agones-images/agones-sdk:0.8.0-5022b65
image: gcr.io/agones-images/agones-ping:0.8.0-5022b65
Linux C++ SDK (build: dev): agonessdk-0.8.0-5022b65-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-5022b65-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-5022b65-src.zip
SDK Server: agonessdk-server-0.8.0-5022b65.zip

A preview of the website will exist for the next 30 days:

https://5022b65-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/551/head:pr_551 && git checkout pr_551
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-5022b65

cyriltovena merged commit dd75eb8 into googleforgames:master

markmandel added kind/feature area/operations labels

markmandel added this to the 0.8.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/operations kind/feature