Speed up builds by using local go/zip instead of dockerized ones. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds LOCAL_GO and LOCAL_ZIP which cause locally-installed Go toolkit and zip tool to be used when building binaries, greatly speeding up incremental rebuilds on a Mac where docker filesystem driver is very slow. Before: ``` $ time make -j4 build-controller-binary build-agones-sdk-binary real 1m11.369s user 0m0.325s sys 0m0.273s ``` After: ``` $ time make -j4 build-controller-binary build-agones-sdk-binary LOCAL_GO=1 LOCAL_ZIP=1 real 0m4.605s user 0m3.480s sys 0m4.527s ``` Note that when using LOCAL_GO, agones.dev must be checked out in a GOPATH and Go compiler must be installed at appropriate version. Use at your own risk!
jkowalski
force-pushed
the
local-go-build
branch
from
ebebdb6 to
a1a9ea5
Compare
|
Build Succeeded 👏 Build Id: 3ff24c97-7ffd-489e-ad18-d204e22fb3a2 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
cyriltovena
approved these changes
Jan 24, 2019
|
Build Succeeded 👏 Build Id: 4889a759-aa27-4e96-94e9-b2b2c3110401 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
nice speedup, although not as dramatic as what I can see, can you merge? |
markmandel
added
the
area/build-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds LOCAL_GO and LOCAL_ZIP which cause locally-installed Go toolkit and zip tool to be used when building binaries, greatly speeding up incremental rebuilds on a Mac where docker filesystem driver is very slow.
Before:
After:
Note that when using LOCAL_GO, agones.dev must be checked out in a GOPATH and Go compiler must be installed at appropriate version.
Use at your own risk!
This pretty fixes #453 as the incremental build times are finally good.