Fixes for flaky e2e tests. #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed 😱 Build Id: fe57c6b3-c5e8-4359-b3a8-e79579d7f7bf Build Logs |
markmandel
force-pushed
the
flaky/TestTlsWebhook
branch
from
4f20388 to
0dcf8ac
Compare
|
Build Succeeded 👏 Build Id: 33ab0989-1f9e-4ee4-aab2-464cfd3731cb The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
jkowalski
reviewed
Jan 24, 2019
| @@ -416,7 +416,17 @@ func TestTlsWebhook(t *testing.T) { | |||
| } | |||
|
|
|||
| // since we're using statically-named service, perform a best-effort delete of a previous service | |||
| framework.KubeClient.CoreV1().Services(defaultNs).Delete(svc.ObjectMeta.Name, waitForDeletion) // nolint:errcheck | |||
| err = framework.KubeClient.CoreV1().Services(defaultNs).Delete(svc.ObjectMeta.Name, waitForDeletion) | |||
There was a problem hiding this comment.
needs DeepCopy() here to avoid data race
There was a problem hiding this comment.
👍 deepcopying all the things.
Some more fixes for the flaky e2e tests.
markmandel
force-pushed
the
flaky/TestTlsWebhook
branch
from
0dcf8ac to
534d2f3
Compare
|
Build Succeeded 👏 Build Id: 5c8a1111-a787-47aa-a0ea-a7086d1b6bbc The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more fixes for the flaky e2e tests.
I'm hoping the makes things stable again! 🍰