Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go download link has changed #494

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Go download link has changed #494

merged 1 commit into from
Jan 20, 2019

Conversation

markmandel
Copy link
Member

I was noticing a flakiness in the download of the go language installer. This change in download location should fix this.

@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jan 18, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 18, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 285f5901-720e-4ce1-a813-73dbe5ae406c

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/494/head:pr_494 && git checkout pr_494
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-ab42c2e

@markmandel markmandel mentioned this pull request Jan 18, 2019
Merged
@markmandel
Go download link has changed
c796adc 
I was noticing a flakiness in the download of the
go language installer. This change in download
location should fix this.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1b7938ca-4eab-4932-84e1-f847d972bebf

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/494/head:pr_494 && git checkout pr_494
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-c796adc

cyriltovena
cyriltovena approved these changes Jan 20, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit 327ece5 into googleforgames:master Jan 20, 2019
@markmandel markmandel deleted the flaky/go-download branch January 20, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs.
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena