Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify resource limits on simple-udp/fleet.yaml #487

Merged
merged 2 commits into from
Jan 17, 2019
Merged

specify resource limits on simple-udp/fleet.yaml #487

merged 2 commits into from
Jan 17, 2019

Conversation

jkowalski
Copy link
Contributor

This allows simple-udp to be used for scale testing of GS controller with fewer nodes.

@markmandel
Copy link
Member

Why both requests and limits? i don't think it makes sense to use both?

Probably makes life easier to just use a request, so it can burst if need be, but will still give direction to the scheduler.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c74477e5-8365-46e6-bef2-a333f0451df5

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/487/head:pr_487 && git checkout pr_487
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-d882864

@jkowalski
Copy link
Contributor Author

Why both requests and limits? i don't think it makes sense to use both?

Probably makes life easier to just use a request, so it can burst if need be, but will still give direction to the scheduler.

Take a look at:

https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/resource-qos.md

Basically if you specify limit==request, Kubernetes will put the pod in the Guaranteed class and:

"Guaranteed pods are considered top-priority and are guaranteed to not be killed until they exceed their limits, or if the system is under memory pressure and there are no lower priority containers that can be evicted."

markmandel
markmandel approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b6421d26-9e6f-48cc-9030-9f653650e754

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/487/head:pr_487 && git checkout pr_487
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-2ea8eb7

@markmandel markmandel merged commit 0a2865d into googleforgames:master Jan 17, 2019
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Jan 24, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 24, 2019
@suecideTech suecideTech mentioned this pull request Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkowalski @markmandel @agones-bot