Mark GameServer Unhealthy if allocated HostPort isn't available #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
|
Build Succeeded 👏 Build Id: a3f2d3f3-30b3-4ccd-87f3-55a4e6489e4a The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
EricFortin
reviewed
Nov 12, 2018
pkg/gameservers/health.go
Outdated
| case v1alpha1.Starting: | ||
| hc.logger.WithField("key", key).Info("GameServer cannot start on this port") | ||
| unhealthy = true | ||
| reason = "No more of the allocated ports free" |
There was a problem hiding this comment.
Your method and test works with free ports but your real code return a string with ports free. These need to be aligned.
This marks a GameServer as unhealthy is the allocated port isn't available on a given Node for whatever reason. Since it's marked as Unhealthy, the Fleet controller will delete it, and the new GameServer will be allocated a new random port that it deems open and available. I've yet to see this in the wild, but I had mild concerns, so figured I'd fix it now rather than later.
markmandel
force-pushed
the
features/port-missing
branch
from
f7aaa34 to
243a869
Compare
|
Build Succeeded 👏 Build Id: f578ecf8-e4ef-40ff-9b6a-be520e08c392 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
EricFortin
approved these changes
Nov 13, 2018
|
Build Failed 😱 Build Id: ac3b590b-5c54-44a0-ba20-7e87b0c47617 Build Logs |
|
Build Succeeded 👏 Build Id: 6862e85a-5b60-4089-a974-d72c895d1f46 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks a GameServer as unhealthy is the allocated port isn't available on a given Node for whatever reason.
Since it's marked as Unhealthy, the Fleet controller will delete it, and the new GameServer will be allocated a new random port that it deems open and available.
I've yet to see this in the wild, but I had mild concerns, so figured I'd fix it now rather than later.