Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Autoscaling: safe-to-evict=false annotations for GameServer Pods #405

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

markmandel
Copy link
Member

This is the final piece for ensuring that the Kubernetes Autoscaler works with Agones.

This ensures that GameServer Pods cannot be evicted from the cluster, via annotations that the autoscaler uses to determine that GameServer Pods are unsafe to be evicted.

This annotation has also been placed on the controller, but can be turned off via Helm chart variables.

I expect that cluster autoscaling, and the backing strategies will get tweaked for performance and resource usage as we get more real world experience with it, but this is working relatively nicely right now.

Closes #368

This is the final piece for ensuring that the Kubernetes Autoscaler
works with Agones.

This ensures that `GameServer` Pods cannot be evicted from the cluster, via
annotations that the autoscaler uses to determine that `GameServer` Pods
are unsafe to be evicted.

This annotation has also been placed on the controller, but can be turned off
via Helm chart variables.

I expect that cluster autoscaling, and the backing strategies will get tweaked
for performance and resource usage as we get more real world experience with it,
but this is working relatively nicely right now.

Closes googleforgames#368
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Nov 6, 2018
@markmandel markmandel added this to the 0.6.0 milestone Nov 6, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 07d27f10-250f-419b-9219-71df196e5210

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/405/head:pr_405 && git checkout pr_405
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-51cdea7

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit e3e7cf4 into googleforgames:master Nov 6, 2018
@markmandel markmandel deleted the feature/autoscaler branch November 6, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants