Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label #3809

Merged
merged 5 commits into from
May 1, 2024
Merged

Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label #3809

merged 5 commits into from
May 1, 2024

Conversation

vicentefb
Copy link
Collaborator

@vicentefb vicentefb commented Apr 29, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
These changes are the first two steps towards #3721
-Adds an AutopilotPassthroughPort Feature Gate
-Adds a new label, e.g. agones.dev/port: "autopilot-passthrough"

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
none

@github-actions github-actions bot added kind/feature New features for Agones size/S labels Apr 29, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ce333538-268b-492f-a741-7857ecc52c10

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-0a93454-amd64

zmerlynn
zmerlynn requested changes Apr 30, 2024
View reviewed changes
pkg/gameservers/controller.go Outdated Show resolved Hide resolved
pkg/gameservers/controller.go Outdated Show resolved Hide resolved
pkg/gameservers/controller_test.go Outdated Show resolved Hide resolved
pkg/util/runtime/features.go Outdated Show resolved Hide resolved
@vicentefb vicentefb requested a review from zmerlynn April 30, 2024 18:09
@vicentefb vicentefb force-pushed the Passthrough_Autopilot branch from 42b22b6 to 3f537cb Compare April 30, 2024 18:30
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a7f42a4b-efc8-4d4e-be57-0ed9198967c4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-3f537cb-amd64

zmerlynn
zmerlynn reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a couple of nits

pkg/cloudproduct/gke/gke.go Outdated Show resolved Hide resolved
pkg/gameservers/controller.go Outdated Show resolved Hide resolved
pkg/cloudproduct/gke/gke_test.go Show resolved Hide resolved
@github-actions github-actions bot added the size/M label May 1, 2024
@vicentefb vicentefb requested a review from zmerlynn May 1, 2024 04:15
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 44695950-17ae-4a37-b1ea-591027536a7c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@vicentefb vicentefb force-pushed the Passthrough_Autopilot branch 2 times, most recently from e2bf06c to 3b014d9 Compare May 1, 2024 04:29
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a66cb13a-373a-419a-9727-140c20415862

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-3b014d9-amd64

@vicentefb vicentefb force-pushed the Passthrough_Autopilot branch from 3b014d9 to 3b14d24 Compare May 1, 2024 20:31
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5f7171f8-451f-4a44-a2ee-13bebfde06e4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-3b14d24-amd64

@zmerlynn zmerlynn merged commit ef2d0b5 into googleforgames:main May 1, 2024
4 checks passed
spiceratops referenced this pull request in spiceratops/k8s-gitops Jun 8, 2024
@spiceratops
feat(helm): update chart agones to 1.41.0 (#790)
bc2dcf4 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [agones](https://agones.dev)
([source](https://togithub.com/googleforgames/agones)) | minor |
`1.40.0` -> `1.41.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleforgames/agones (agones)</summary>

###
[`v1.41.0`](https://togithub.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1410-2024-06-04)

[Compare
Source](https://togithub.com/googleforgames/agones/compare/v1.40.0...v1.41.0)

[Full
Changelog](https://togithub.com/googleforgames/agones/compare/v1.40.0...v1.41.0)

**Implemented enhancements:**

- Configure Allocator Status Code by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3782](https://togithub.com/googleforgames/agones/pull/3782)
- Graduate Counters and Lists to Beta by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3801](https://togithub.com/googleforgames/agones/pull/3801)
- Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate
and new pod label by [@&#8203;vicentefb](https://togithub.com/vicentefb)
in
[https://github.com/googleforgames/agones/pull/3809](https://togithub.com/googleforgames/agones/pull/3809)
- CountsAndLists: Move to Beta Protobuf by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3806](https://togithub.com/googleforgames/agones/pull/3806)
- feat: support multiple port ranges by
[@&#8203;nrwiersma](https://togithub.com/nrwiersma) in
[https://github.com/googleforgames/agones/pull/3747](https://togithub.com/googleforgames/agones/pull/3747)
- Changes `sdk-server` to Patch instead of Update by
[@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3803](https://togithub.com/googleforgames/agones/pull/3803)
- Generate grpc for nodejs from alpha to beta by
[@&#8203;lacroixthomas](https://togithub.com/lacroixthomas) in
[https://github.com/googleforgames/agones/pull/3825](https://togithub.com/googleforgames/agones/pull/3825)
- Update CountsAndLists from Alpha to Beta by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3824](https://togithub.com/googleforgames/agones/pull/3824)
- feat(gameserver): New DirectToGameServer PortPolicy allows direct
traffic to a GameServer by
[@&#8203;daniellee](https://togithub.com/daniellee) in
[https://github.com/googleforgames/agones/pull/3807](https://togithub.com/googleforgames/agones/pull/3807)
- Passthrough autopilot - Adds mutating webhook by
[@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3833](https://togithub.com/googleforgames/agones/pull/3833)
- Passthrough autopilot - added ports array case and updated unit tests
by [@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3842](https://togithub.com/googleforgames/agones/pull/3842)
- Nodejs counters and lists by
[@&#8203;steven-supersolid](https://togithub.com/steven-supersolid) in
[https://github.com/googleforgames/agones/pull/3726](https://togithub.com/googleforgames/agones/pull/3726)
- Promote AutopilotPassthroughPort feature gate to Alpha by
[@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3849](https://togithub.com/googleforgames/agones/pull/3849)

**Fixed bugs:**

- Helm Param Update: Default to agones.controller if agones.extensions
is Missing by [@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84)
in
[https://github.com/googleforgames/agones/pull/3773](https://togithub.com/googleforgames/agones/pull/3773)
- fix: rollout strategy issues by
[@&#8203;nrwiersma](https://togithub.com/nrwiersma) in
[https://github.com/googleforgames/agones/pull/3762](https://togithub.com/googleforgames/agones/pull/3762)
- Set Minimum Buffer Size to 1 by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3749](https://togithub.com/googleforgames/agones/pull/3749)
- Pin ltsc2019 to older SHA by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3829](https://togithub.com/googleforgames/agones/pull/3829)
- TestGameServerAllocationDuringMultipleAllocationClients: Readdress
flake by [@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3831](https://togithub.com/googleforgames/agones/pull/3831)
- Refactor finalizer name to include valid domain name and path by
[@&#8203;indexjoseph](https://togithub.com/indexjoseph) in
[https://github.com/googleforgames/agones/pull/3840](https://togithub.com/googleforgames/agones/pull/3840)
- agones-{extensions,allocator}: Be more defensive about draining by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3839](https://togithub.com/googleforgames/agones/pull/3839)
- agones-{extensions,allocator}: Pause after cancelling context by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3843](https://togithub.com/googleforgames/agones/pull/3843)
- Change the line to modify in Quickstart: Edit a Game Server by
[@&#8203;peterzhongyi](https://togithub.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3844](https://togithub.com/googleforgames/agones/pull/3844)

**Other:**

- Prep for Release v1.41.0 by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3800](https://togithub.com/googleforgames/agones/pull/3800)
- Update site documentation to reflect firewall prefix and default to
Autopilot cluster creation for Agones by
[@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3769](https://togithub.com/googleforgames/agones/pull/3769)
- Add a System Diagram and overview page by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3792](https://togithub.com/googleforgames/agones/pull/3792)
- Update Side Menu: Preserve and Restore Scroll Position by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3805](https://togithub.com/googleforgames/agones/pull/3805)
- fix: typo by [@&#8203;skmpf](https://togithub.com/skmpf) in
[https://github.com/googleforgames/agones/pull/3808](https://togithub.com/googleforgames/agones/pull/3808)
- Helm Config: Add httpUnallocatedStatusCode in Allocator Service by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3802](https://togithub.com/googleforgames/agones/pull/3802)
- Update Docs: CountersAndLists to Beta by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3810](https://togithub.com/googleforgames/agones/pull/3810)
- Disable Dev feature FeatureAutopilotPassthroughPort by
[@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3815](https://togithub.com/googleforgames/agones/pull/3815)
- Disable FeatureAutopilotPassthroughPort in features.go by
[@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3816](https://togithub.com/googleforgames/agones/pull/3816)
- SDK proto compatibility guarantees and deprecation policies
documentation by [@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3774](https://togithub.com/googleforgames/agones/pull/3774)
- Fix dangling "as of" by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3827](https://togithub.com/googleforgames/agones/pull/3827)
- Steps to Promote SDK Features from Alpha to Beta by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3814](https://togithub.com/googleforgames/agones/pull/3814)
- Adds comment for help troubleshooting issues with terraform tfstate by
[@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3822](https://togithub.com/googleforgames/agones/pull/3822)
- docs: improve counter and list example comments by
[@&#8203;yonbh](https://togithub.com/yonbh) in
[https://github.com/googleforgames/agones/pull/3818](https://togithub.com/googleforgames/agones/pull/3818)
- Skip /tmp/ on yamllint by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3838](https://togithub.com/googleforgames/agones/pull/3838)
- TestAllocatorAfterDeleteReplica: More logging by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3837](https://togithub.com/googleforgames/agones/pull/3837)
- Instructions for upgrading golang version by
[@&#8203;gongmax](https://togithub.com/gongmax) in
[https://github.com/googleforgames/agones/pull/3819](https://togithub.com/googleforgames/agones/pull/3819)
- Remove unused function FindGameServerContainer by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3841](https://togithub.com/googleforgames/agones/pull/3841)
- Adds Unreal to the List of URL Links to Not Check by
[@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3847](https://togithub.com/googleforgames/agones/pull/3847)
- docs: clarify virtualization setup for Windows versions by
[@&#8203;andresromerodev](https://togithub.com/andresromerodev) in
[https://github.com/googleforgames/agones/pull/3850](https://togithub.com/googleforgames/agones/pull/3850)

**New Contributors:**

- [@&#8203;skmpf](https://togithub.com/skmpf) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3808](https://togithub.com/googleforgames/agones/pull/3808)
- [@&#8203;yonbh](https://togithub.com/yonbh) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3818](https://togithub.com/googleforgames/agones/pull/3818)
- [@&#8203;peterzhongyi](https://togithub.com/peterzhongyi) made their
first contribution in
[https://github.com/googleforgames/agones/pull/3844](https://togithub.com/googleforgames/agones/pull/3844)
- [@&#8203;andresromerodev](https://togithub.com/andresromerodev) made
their first contribution in
[https://github.com/googleforgames/agones/pull/3850](https://togithub.com/googleforgames/agones/pull/3850)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
@vicentefb vicentefb mentioned this pull request Oct 15, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicentefb @agones-bot @zmerlynn