Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions for Minikube 0.29.0 #373

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Update instructions for Minikube 0.29.0 #373

merged 2 commits into from
Oct 5, 2018

Conversation

markmandel
Copy link
Member

Changed the documentation to work for minikube 0.29.0, as well as updating the development tools.

@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Oct 4, 2018
@markmandel markmandel added this to the 0.5.0 milestone Oct 4, 2018
@markmandel
Update instructions for Minikube 0.29.0
13bdb9e 
Changed the documentation to work for minikube 0.29.0,
as well as updating the development tools.
@markmandel markmandel force-pushed the cleanup/minikube-0.29.0 branch from 3fdbdfe to 13bdb9e Compare October 4, 2018 03:18
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 90e7412e-be34-4a07-bdbb-e69f9bf154b5

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/373/head:pr_373 && git checkout pr_373
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.5.0-13bdb9e

cyriltovena
cyriltovena approved these changes Oct 5, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e03ed105-114b-45c4-b747-30cba8cf62bb

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/373/head:pr_373 && git checkout pr_373
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.5.0-958cb48

@markmandel markmandel merged commit df82946 into googleforgames:master Oct 5, 2018
@markmandel markmandel deleted the cleanup/minikube-0.29.0 branch October 5, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena