Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding goimports back into the build shell. #352

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Adding goimports back into the build shell. #352

merged 1 commit into from
Sep 11, 2018

Conversation

markmandel
Copy link
Member

No description provided.

@markmandel markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Sep 11, 2018
@markmandel markmandel added this to the 0.5.0 milestone Sep 11, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c1c284b3-09fd-4471-bf1b-97ab4954cbbb

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/352/head:pr_352 && git checkout pr_352
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.5.0-7ea1b17

cyriltovena
cyriltovena approved these changes Sep 11, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit 5ee93f8 into googleforgames:master Sep 11, 2018
@markmandel markmandel deleted the tools/goimports branch September 11, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena