-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GameServer addresses to the allocation APIs #3307
Conversation
Build Succeeded 👏 Build Id: 07418272-9192-45b9-b80a-f03ed464c6d9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick pass and lgtm. Will defer to others for a more thorough review.
Build Succeeded 👏 Build Id: 06ff31e6-751a-4f3b-a537-edcff0fec277 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
4ebeda4
to
88f0ad8
Compare
Build Succeeded 👏 Build Id: ef13e5cd-ab60-451d-ad67-c8a24a8c9ef7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow on from #3299:
addresses
to allocation proto andGameServerAllocation
responseaddress
andaddresses
on GameServer reference pageNote to reviewer: Commits starting with
make
are auto-generated bits, you can skip them (probably)Closes #3089
Next steps: I'm going to test this with IPv6 to verify, then likely write an integration guide (done in #3311), which should be enough to complete #3134