Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GameServer addresses to the allocation APIs #3307

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Aug 2, 2023

Follow on from #3299:

  • Add addresses to allocation proto and GameServerAllocation response
  • Document address and addresses on GameServer reference page

Note to reviewer: Commits starting with make are auto-generated bits, you can skip them (probably)

Closes #3089
Next steps: I'm going to test this with IPv6 to verify, then likely write an integration guide (done in #3311), which should be enough to complete #3134

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 07418272-9192-45b9-b80a-f03ed464c6d9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3307/head:pr_3307 && git checkout pr_3307
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-43a04b0-amd64

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass and lgtm. Will defer to others for a more thorough review.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 06ff31e6-751a-4f3b-a537-edcff0fec277

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3307/head:pr_3307 && git checkout pr_3307
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-4ebeda4-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ef13e5cd-ab60-451d-ad67-c8a24a8c9ef7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3307/head:pr_3307 && git checkout pr_3307
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-88f0ad8-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit d524a6c into googleforgames:main Aug 3, 2023
@markmandel markmandel added kind/feature New features for Agones and removed kind/other labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return all advertised Gameserver Addresses
5 participants