Move Status > Address & Ports population to Creating state processing
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the IP and Ports of the GameServer were populated only when the GameServer is set to Ready. This information may be needed by the GameServer process before the process actually wants to mark itself as Ready. Therefore, port and address population has been moved to the `Creating` state processing, as that is where the Pod is created, and therefore we have both address and port information. `GameServer` events now look like this: ``` Events: Type Reason Age From Message ---- ------ ---- ---- ------- Normal PortAllocation 17s gameserver-controller Port allocated Normal Creating 16s gameserver-controller Pod simple-udp-fcf44 created Normal Starting 16s gameserver-controller Address and Port populated Normal Ready 15s gameserver-controller SDK.Ready() executed ``` Closes googleforgames#293
markmandel
added
kind/feature
|
Build Succeeded 👏 Build Id: 9f70cce2-9f3f-47c9-9a29-1d6da652b546 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
|
Looks ok to me but I'm no go guru, to put it mildly.... But this feature îs definitely helpful, am glad to see it. |
|
I spent about 30 minutes looking this morning and couldn't see anything obviously wrong but very new to this. Will also see if I can check out a couple of PRs over the weekend |
cyriltovena
approved these changes
Aug 26, 2018
|
Build Succeeded 👏 Build Id: 061478e9-63f3-4a43-a10c-b80127d92a49 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the IP and Ports of the
GameServerwere populated only when theGameServeris set to Ready.This information may be needed by the
GameServerprocess before the process actually wants to mark itself as Ready.Therefore, port and address population has been moved to the
Creatingstate processing, as that is where the Pod is created, and therefore we have both address and port information.GameServerevents now look like this:Closes #293