-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakiness with TestSidecarHTTPHealthCheck #313
Merged
markmandel
merged 2 commits into
googleforgames:master
from
markmandel:flaky/test-sidecar-http
Aug 1, 2018
Merged
Fix flakiness with TestSidecarHTTPHealthCheck #313
markmandel
merged 2 commits into
googleforgames:master
from
markmandel:flaky/test-sidecar-http
Aug 1, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that this is starting at the same time as another http server on the same port, and having a collision. Removing the parrallel marker should fix this.
Build Succeeded 👏 Build Id: 611fe503-354b-4e12-99ab-6bc930b3b9de The following development artifacts have been built, and will exist for the next 30 days:
|
cyriltovena
approved these changes
Jul 31, 2018
Build Failed 😱 Build Id: 23c6dfe3-5390-4a6f-98b0-6fadca94ad11 Build Logs
|
Build Succeeded 👏 Build Id: 3cfcdb88-01c4-4c0c-afcf-2a411f061766 The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this is starting at the same time as another
http server on the same port, and having a collision.
Removing the parrallel marker should fix this.