Update the apiserver request dashboard #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is nearly unreviewable, so I'm attaching a screenshot to the PR. Changes: * The original metrics were deprecated. `apiserver_request_total` exactly replaces `apiserver_request_count`, but the old `apiserver_request_latencies_summary`, which was a gauge, was replaced by `apiserver_request_duration_seconds_bucket`, which is a historgram type. Changed the expressions to match these changes. * Transitioned to $__rate_interval instead of 5m, per recommendation: https://grafana.com/docs/grafana/latest/datasources/prometheus/template-variables/#use-__rate_interval * Fixed an issue where `label_values(label)` isn't supported on GMP (it seems - probably because this goes across ALL metrics), but `label_values(label, metric)` is - this is a change I'll need to make on nearly every other dashboard but I'll get there later. * Upgraded the graph from a deprecated graph type to the new time series type.
|
Build Succeeded 👏 Build Id: 983b0e92-5345-4d46-a05a-0eb10f964916 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
gongmax
approved these changes
Feb 11, 2023
markmandel
removed this pull request from the merge queue due to the queue being cleared
|
Build Failed 😱 Build Id: 593ab3b8-d123-4e29-ae59-a6ad0f877dc0 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: a2036a22-cbf0-4252-b7c6-3d384856fc11 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
approved these changes
Feb 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: b7eefa2d-3b62-4c14-abc7-09619dc292a4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Feb 22, 2023
Google Managed Prometheus (GMP) doesn't support unscoped label_values(label), instead requiring label_values(metric, label). There's one more use left after googleforgames#2963 - fix it. Along the way, remove a spurious tab in another dashboard.
zmerlynn
added a commit
that referenced
this pull request
Feb 22, 2023
Google Managed Prometheus (GMP) doesn't support unscoped label_values(label), instead requiring label_values(metric, label). There's one more use left after #2963 - fix it. Along the way, remove a spurious tab in another dashboard.
Kalaiselvi84
added
the
area/meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nearly unreviewable, so here's a screenshot:
Changes:
The original metrics were deprecated.
apiserver_request_totalexactly replacesapiserver_request_count, but the oldapiserver_request_latencies_summary, which was a gauge, was replaced byapiserver_request_duration_seconds_bucket, which is a historgram type. Changed the expressions to match these changes.Transitioned to $__rate_interval instead of 5m, per recommendation: https://grafana.com/docs/grafana/latest/datasources/prometheus/template-variables/#use-__rate_interval
Fixed an issue where
label_values(label)isn't supported on GMP (it seems - probably because this goes across ALL metrics), butlabel_values(label, metric)is - this is a change I'll need to make on nearly every other dashboard but I'll get there later.Upgraded the graph from a deprecated graph type to the new time series type.
I created this PR by using "Save", then copying the JSON blob back to the configmap. I then compensated for the new "fixed" UID datasource by applying this hack: grafana/grafana#45230 (comment) .