controller/extensions: Add explicit requests/limits for ephemeral storage #2900
Conversation
zmerlynn
added
the
feature-freeze-do-not-merge
zmerlynn
requested review from
markmandel and
roberthbailey
and removed request for
cyriltovena and
dzlier-gcp
|
Build Failed 😱 Build Id: 293eabb7-f34d-4c7d-a820-6cb39dfdbb82 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: dc85e748-5d79-4b51-a0ca-b6b328d3bc94 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
force-pushed
the
limit-ephemeral-storage
branch
2 times, most recently
from
426b34b to
4179163
Compare
|
Build Failed 😱 Build Id: 8b911009-e39d-4692-928d-141633fc65bd To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 9e33eb92-b992-41ef-9c1b-c9e0af824a9b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Kalaiselvi84
removed
the
feature-freeze-do-not-merge
|
Looking at the generated install.yaml, it looks like the ephemeral storage is nudged up to |
I changed the commit text but forgot to backpropagate it to the PR description - fixed now. |
…rage
On Autopilot, ephemeral storage defaults to a request/limit of 1GiB,
but on Agones we assume there's no ephemeral storage limit. The
default persistent log limit is 10GB.
In this PR, we adds a default resources.{limits,requests} block to the
controller if the user has not already specified `resources` and set
it to the persistent log maximum plus a fudge factor of 100MB to allow
for the certs and some overhead. By default this comes out to 10100MB,
which slides under the Autopilot 10GiB limit by virtue of GiB/MB
differences.
Towards googleforgames#2777
zmerlynn
force-pushed
the
limit-ephemeral-storage
branch
from
4179163 to
46ce09a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 2b931ac2-c3d7-45bd-9dcf-29fdef6d9f44 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 9a2d4741-602f-4170-93dd-a3cf9486f156 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
On Autopilot, ephemeral storage defaults to a request/limit of 1GiB, but on Agones we assume there's no ephemeral storage limit. The default persistent log limit is 10GB.
In this PR, we add a default
resources.{limits,requests}block to the controller if the user has not already specifiedresourcesand set it to the persistent log maximum plus a fudge factor of 100MB to allow for the certs and some overhead. By default this comes out to 10100MB, which slides under the Autopilot 10GiB limit by virtue of GiB/MB differences.Towards #2777