Update aws-sdk-go version to latest

[gongmax]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markmandel]

Looks good to me!

@mangalpalli - we should probably hold off on RC until this lands, since it's a security fix.

[markmandel]

Maybe a silly question - what happens if we remove the dependency for aws-sdk-go - I can't find a reference for it anywhere in the code?

❯ go mod why github.com/aws/aws-sdk-go
# github.com/aws/aws-sdk-go
(main module does not need package github.com/aws/aws-sdk-go)

I wonder if it's actually needed?

[markmandel]

Maybe a silly question - what happens if we remove the dependency for aws-sdk-go - I can't find a reference for it anywhere in the code?

Actually ignore me - it's an indirect. I just can't find a good way to see the dependency tree.

[agones-bot]

Build Failed 😱

Build Id: 389decec-fa0f-40ba-8c5c-c724785ee28d

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Flake

--- FAIL: TestFleetRollingUpdate (0.00s)
    --- FAIL: TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true (112.14s)

[markmandel]

Found a way to look at dependencies!

❯ go mod graph | grep aws
agones.dev/agones github.com/aws/[email protected]
contrib.go.opencensus.io/exporter/[email protected] github.com/aws/[email protected]
github.com/aws/[email protected] github.com/jmespath/[email protected]
github.com/aws/[email protected] github.com/go-ini/[email protected]
github.com/aws/[email protected] github.com/jmespath/[email protected]

[agones-bot]

Build Failed 😱

Build Id: f789b3e0-f0ac-4c07-9030-3f0cdd5044d5

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: d041ee66-20bd-45b7-8e97-8e9cebf59397

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-6e06d51-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-6e06d51-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-6e06d51-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-6e06d51-amd64
• Linux C++ SDK (build): agonessdk-1.29.0-6e06d51-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.29.0-6e06d51-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://6e06d51-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2894/head:pr_2894 && git checkout pr_2894
• helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-6e06d51-amd64