Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the .scheduling field in the fleet and gameserverset #2892

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Validate the .scheduling field in the fleet and gameserverset #2892

merged 1 commit into from
Jan 21, 2023

Conversation

zmerlynn
Copy link
Collaborator

Adds a cloud product hook specific to the scheduling field, for use in the fleet / gameserverset APIs. This might seem narrowly scoped, but this field is the only one that propagates down outside the template.

Towards #2777

@zmerlynn zmerlynn requested review from markmandel and removed request for EricFortin January 10, 2023 00:06
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8d1e4e20-9dac-49b5-a72e-13b6a7ff4fa5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2892/head:pr_2892 && git checkout pr_2892
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-b5f65b7-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 47a58a9b-4758-4913-a342-48fbbaa9139b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 01ed019c-bc57-419b-bba0-4d4ecedab45f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2892/head:pr_2892 && git checkout pr_2892
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-2d2924c-amd64

@Kalaiselvi84 Kalaiselvi84 added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jan 11, 2023
@Kalaiselvi84 Kalaiselvi84 removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jan 18, 2023
@roberthbailey roberthbailey self-assigned this Jan 19, 2023
@roberthbailey
Copy link
Member

I can't pull the branch forward as it looks like there is a conflict you will need to resolve manually.

@zmerlynn
Copy link
Collaborator Author

I can't pull the branch forward as it looks like there is a conflict you will need to resolve manually.

Resolved, PTAL!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cc043461-c125-4e13-b9ff-fad42a017747

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2892/head:pr_2892 && git checkout pr_2892
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-d2d99a0-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 330945ef-dcf8-4959-960d-0e97235c101c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2892/head:pr_2892 && git checkout pr_2892
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-5a8d180-amd64

@zmerlynn
Validate the .scheduling field in the fleet and gameserverset
5bff3a5 
Adds a cloud product hook specific to the scheduling field, for use in
the fleet / gameserverset APIs. This might seem narrowly scoped, but
this field is the only one that propagates down outside the template.

Modifies one e2e to test that Autopilot rejects appropriately. Adds
several skips to other tests.

Towards googleforgames#2777
@zmerlynn
Copy link
Collaborator Author

PTAL, thanks!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b9597837-e168-4c3f-a49f-0befc3e5d811

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2892/head:pr_2892 && git checkout pr_2892
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-5bff3a5-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Jan 21, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn merged commit 713a76e into googleforgames:main Jan 21, 2023
@zmerlynn zmerlynn deleted the validate-fleet branch January 21, 2023 23:11
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones and removed area/tests Unit tests, e2e tests, anything to make sure things don't break labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel left review comments

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
approved kind/feature New features for Agones lgtm size/M
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zmerlynn @agones-bot @roberthbailey @markmandel @Kalaiselvi84