Inline JSON: GameServerAllocation v1.LabelSelector #2877
Conversation
markmandel
added
kind/bug
|
Build Failed 😱 Build Id: fa9f5b34-a636-4b5f-b10f-1b3ffec863b9 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Ooops, forgot to regenerate things. |
The K8s YAML library will inline embeded structs, but some other ones will not. So adding the `json:",inline"` hint, so that they know that the `v1.LabelSelector` should be inlined if people are so inclined to reference it via Golang yaml libraries. Include regeneration of the crd docs and client libraries, which picked up on some small changes. Closes googleforgames#2853
markmandel
force-pushed
the
bug/selector-inline
branch
from
0d11a1d to
c61a21a
Compare
|
Build Succeeded 👏 Build Id: 744c5ee5-9a26-4f76-b799-636f241f2865 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / Why we need it:
The K8s YAML library will inline embeded structs, but some other ones will not. So adding the
json:",inline"hint, so that they know that thev1.LabelSelectorshould be inlined if people are so inclined to reference it via Golang yaml libraries.Which issue(s) this PR fixes:
Closes #2853
Special notes for your reviewer:
Include regeneration of the crd docs and client libraries, which picked up on some small changes.