-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert workload separation for Autopilot #2876
Revert workload separation for Autopilot #2876
Conversation
Workload separation on Autopilot requires 0.5 vCPU per pod vs the 0.25 vCPU per pod normally required (see https://cloud.google.com/kubernetes-engine/docs/concepts/autopilot-resource-requests#compute-class-min-max vs https://cloud.google.com/kubernetes-engine/docs/concepts/autopilot-resource-requests#workload-separation) A lot of users have smaller pods. Revert the automatic use of workload separation. I will work internally to figure out how we might change this. For the time being, I will work towards how we might document this. It's relatively straightforward if a user needs to, as this block was just adding the equivalent of: ``` tolerations: - key: agones.dev/role operator: Equal value: gameserver effect: NoSchedule nodeSelector: agones.dev/role: gameserver ``` But with documentation, we can show other options as well, i.e. how to have workload separation between different gameserver workloads if desired. Towards googleforgames#2777
Build Failed 😱 Build Id: 473d6572-637a-4cd3-aa76-0bed01ba1552 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 716e3bc1-9800-445e-b077-5d5f8aad988c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 395878d5-578e-4770-b9bb-1fdac5093860 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Workload separation on Autopilot requires 0.5 vCPU per pod vs the 0.25 vCPU per pod normally required (see minimum vs
workload separation). Unfortunately, a lot of users have smaller game server pods. Revert the automatic use of workload separation. I will work internally to figure out how we might change the minimums.
For the time being, I will work towards how we might document this. It's relatively straightforward if a user needs to, as this block was just adding the equivalent of:
But with documentation, we can show other options as well, i.e. how to have workload separation between different gameserver workloads if desired.
Towards #2777