lint: Reenable revive
#2874
Merged
lint: Reenable revive
#2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way revive was configured, we configured the confidence interval, but didn't enable any checks, it seems. By deleting the message, it reverts to the default `revive` config, which includes: * Comments on exported symbols must be of the right form (this was noticed as lacking in googleforgames#2868) * Package comments - I'm guessing from the number of changes that we've never had this linter, but given that certain IDEs expect the package to be offset from the header, having this linter enforces it. Closes googleforgames#2873
zmerlynn
force-pushed
the
lint-exported-symbols
branch
from
c760ccb to
9b34c3e
Compare
|
Build Failed 😱 Build Id: f5c6a125-5014-45f6-a98a-5541452f4cbc To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 739561b1-33c4-4093-bb64-afc515ea4af1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
gongmax
approved these changes
Dec 16, 2022
markmandel
approved these changes
Dec 16, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
revivewas configured, we configured the confidence interval, but didn't enable any checks, it seems. By deleting the message, it reverts to the defaultreviveconfig, which includes:Comments on exported symbols must be of the right form (this was noticed as lacking in cloudproduct: Register API hooks, move validation/mutation to API #2868)
Package comments - I'm guessing from the number of changes that we've never had this linter, but given that certain IDEs expect the package to be offset from the header, having this linter enforces it.
Closes #2873