Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update restapi conformance-test #2869

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Update restapi conformance-test #2869

merged 1 commit into from
Dec 15, 2022

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Dec 15, 2022

What type of PR is this?

/kind testing
/area tests

What this PR does / Why we need it:

This PR is followup for #2786.
This PR updates the restapi conformance-test codes.
This updates include the changes of swagger definitions.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

None.

Copy link
Collaborator

@aimuz aimuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Comment on lines 15 to 26
// This code was autogenerated. Do not edit directly.
// Copyright 2022 Google LLC All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be repeated here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already old files. I deleted this.

Comment on lines 15 to 29
// This code was autogenerated. Do not edit directly.
// Copyright 2022 Google LLC All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already old files. I deleted this.

Comment on lines 15 to 29
// This code was autogenerated. Do not edit directly.
// Copyright 2022 Google LLC All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already old files. I deleted this.

*/
package swagger

type GooglerpcStatus struct {

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was auto-generated by Swagger Codegen. So even if I want to edit the file, I can't.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply, I'll hide it

type StreamResultOfSdkGameServer struct {
Result *SdkGameServer `json:"result,omitempty"`
Error_ *GooglerpcStatus `json:"error,omitempty"`

This comment was marked as duplicate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by Swagger Codegen auto-generation.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e5268e79-7e64-442a-ad48-09cc03c4f8a1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Dec 15, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2ca9080a-a9b7-4d7c-9685-a61768c0c901

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2869/head:pr_2869 && git checkout pr_2869
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.29.0-ba00a11-amd64

Copy link
Collaborator

@aimuz aimuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aimuz, govargo, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign pooneh-m for approval by writing /assign @pooneh-m in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) December 15, 2022 17:44
@google-oss-prow google-oss-prow bot removed the lgtm label Dec 15, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1a7dc5f0-b772-4667-bb05-fd97cd3f8882

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2869/head:pr_2869 && git checkout pr_2869
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.29.0-ff7a715-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b0bacdfe-95cd-45e6-865f-f7768218a2f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a6b30729-f9ea-451f-a56f-1f69020a5df8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2869/head:pr_2869 && git checkout pr_2869
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.29.0-e0da767-amd64

@zmerlynn zmerlynn merged commit 4183d7b into googleforgames:main Dec 15, 2022
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants