Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.28.0 release #2852

Merged
merged 7 commits into from
Dec 7, 2022
Merged

1.28.0 release #2852

merged 7 commits into from
Dec 7, 2022

Conversation

mangalpalli
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind release

What this PR does / Why we need it:

RELEASE

Which issue(s) this PR fixes:
#2851

Special notes for your reviewer:

@mangalpalli mangalpalli added the kind/release Checklist for a release label Dec 6, 2022
@mangalpalli mangalpalli added this to the 1.28.0 milestone Dec 6, 2022
@mangalpalli mangalpalli self-assigned this Dec 6, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 00d85dfb-7bc5-4e27-9251-7da16bbfc381

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member 

site/index.html
  Non-OK status: 403 --- site/index.html --> https://vela.games/
  Non-OK status: 404 --- site/index.html --> https://afterverse.com/

Looks like the data-proofer-ignore should go back for these website. They may be blocking bots in some fashion, so we get a 404.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a81f6e68-c9a2-4d2d-b0de-c916de651758

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8d4c3c06-3986-45c9-bc11-1be70d449ad9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Looks like htmltest is passing again, but somehow the index.yaml file has disappeared 🤔

	> /go/src/agones.dev/agones/install/yaml/install.yaml'
make[1]: Leaving directory '/workspace/build'
sort /workspace/install/yaml/install.yaml > /tmp/agones-install/install.current.yaml.sorted
make: *** [Makefile:342: test-install-yaml] Error 1
diff /tmp/agones-install/install.yaml.sorted /tmp/agones-install/install.current.yaml.sorted
13958c13958
<           image: "gcr.io/agones-images/agones-ping:1.28.0-rc"
---
>           image: "gcr.io/agones-images/agones-ping:1.28.0"
14069c14069
<           value: "gcr.io/agones-images/agones-sdk:1.28.0-rc"
---
>           value: "gcr.io/agones-images/agones-sdk:1.28.0"
14182,14183c14182,14183
<         image: "gcr.io/agones-images/agones-allocator:1.28.0-rc"
<         image: "gcr.io/agones-images/agones-controller:1.28.0-rc"
---
>         image: "gcr.io/agones-images/agones-allocator:1.28.0"
>         image: "gcr.io/agones-images/agones-controller:1.28.0"
14373,14400c14373,14400
<     chart: "agones-1.28.0-rc"
<     chart: "agones-1.28.0-rc"
<     chart: "agones-1.28.0-rc"
<     chart: "agones-1.28.0-rc"
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
<     chart: agones-1.28.0-rc
---
>     chart: "agones-1.28.0"
>     chart: "agones-1.28.0"
>     chart: "agones-1.28.0"
>     chart: "agones-1.28.0"
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
>     chart: agones-1.28.0
make: *** Waiting for unfinished jobs....

markmandel
markmandel reviewed Dec 7, 2022
View reviewed changes
site/content/en/docs/Installation/Install Agones/helm.md Outdated

| Parameter | Description | Default |
|---------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|
| `agones.allocator.pdb.enabled` | Set to `true` to enable the creation of a [PodDisruptionBudget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for the allocator deployment | `false` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the line above needs to be removed. See: https://github.com/googleforgames/agones/blob/59eed9a6aed9f69ffe4ee0d3b9ccb6fc89caf1e7/site/content/en/docs/Installation/Install%20Agones/helm.md

The table isn't rendering correctly.

Also, can you group the new config option in the same area as other please? So put the new agones.allocator config options with the others, the new agones.ping options with the others, etc.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2ddc776f-842a-4bb5-889d-27d708adc996

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3d47fab4-9137-4365-bdbd-40c34aac6892

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2852/head:pr_2852 && git checkout pr_2852
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-8462638-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangalpalli, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 4aa721b into googleforgames:main Dec 7, 2022
chiayi pushed a commit to chiayi/agones that referenced this pull request Dec 13, 2022
@mangalpalli @chiayi
1.28.0 release (googleforgames#2852)
3fbac4c 
* Updated helm tag and chart version values
* Updated package versions
* Updated SDK versions
* release-1.28.0 changes
* Review changes
* Markdown file changes
* Added install.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@markmandel markmandel markmandel approved these changes

@gongmax gongmax Awaiting requested review from gongmax

Assignees

@markmandel markmandel

@roberthbailey roberthbailey

@mangalpalli mangalpalli

Labels
approved kind/release Checklist for a release lgtm size/L
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mangalpalli @agones-bot @markmandel @roberthbailey