Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreal SDK fix for setting capacity for Player Tracking and Editor error messages #2846

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

Titantompa
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / Why we need it:
This PR resolves two problems in the Unreal SDK.

  1. Error messages about uninitialized properties is shown in the Unreal Editor at startup. This is from the FDuration and FPlayerCapacity structs not having any default value for their int64 properties.
  2. Failure to set the server's player capacity for Player Tracking. This is due to the original implementation using the incorrect HTTP method.

Which issue(s) this PR fixes:
Closes #2844
Closes #2845

Special notes for your reviewer:
Unreal Engine version 5.1.0

Build logs*

CONSOLE: C:\Program Files\Epic Games\UE_5.0\Engine\Build\BatchFiles\Rebuild.bat  AgonesTestBuildEditor Win64 Development -Project="C:\Users\tomas\Repos\AgonesTestBuild\AgonesTestBuild.uproject" -WaitMutex -FromMsBuild
Cleaning AgonesTestBuildEditor and UnrealHeaderTool binaries...
Using bundled DotNet SDK
Log file: C:\Users\tomas\AppData\Local\UnrealBuildTool\Log.txt
Creating makefile for AgonesTestBuildEditor (no existing makefile)
Parsing headers for AgonesTestBuildEditor
  Running UnrealHeaderTool "C:\Users\tomas\Repos\AgonesTestBuild\AgonesTestBuild.uproject" "C:\Users\tomas\Repos\AgonesTestBuild\Intermediate\Build\Win64\AgonesTestBuildEditor\Development\AgonesTestBuildEditor.uhtmanifest" -LogCmds="loginit warning, logexit warning, logdatabase error" -Unattended -WarningsAsErrors -abslog="C:\Users\tomas\AppData\Local\UnrealBuildTool\Log_UHT.txt" -installed
Reflection code generated for AgonesTestBuildEditor in 2,6697422 seconds
Building AgonesTestBuildEditor...
Using Visual Studio 2022 14.31.31107 toolchain (C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.31.31103) and Windows 10.0.19041.0 SDK (C:\Program Files (x86)\Windows Kits\10).
[Adaptive Build] Excluded from AgonesTestBuild unity file: AgonesTestBuild.cpp, AgonesTestBuildGameModeBase.cpp
Determining max actions to execute in parallel (24 physical cores, 48 logical cores)
  Executing up to 24 processes, one per physical core
Building 14 actions with 14 processes...
[1/14] Resource Default.rc2
[2/14] Resource Default.rc2
[3/14] Compile SharedPCH.Engine.ShadowErrors.cpp
[4/14] Compile AgonesTestBuild.init.gen.cpp
[5/14] Compile AgonesTestBuild.cpp
[6/14] Compile AgonesTestBuildGameModeBase.gen.cpp
[7/14] Compile AgonesTestBuildGameModeBase.cpp
[8/14] Link UnrealEditor-AgonesTestBuild.lib
   Creating library C:\Users\tomas\Repos\AgonesTestBuild\Intermediate\Build\Win64\UnrealEditor\Development\AgonesTestBuild\UnrealEditor-AgonesTestBuild.lib and object C:\Users\tomas\Repos\AgonesTestBuild\Intermediate\Build\Win64\UnrealEditor\Development\AgonesTestBuild\UnrealEditor-AgonesTestBuild.exp
[9/14] Compile Module.Agones.cpp
[10/14] Compile Module.Agones.gen.cpp
[11/14] Link UnrealEditor-Agones.lib
   Creating library C:\Users\tomas\Repos\AgonesTestBuild\Plugins\Agones\Intermediate\Build\Win64\UnrealEditor\Development\Agones\UnrealEditor-Agones.lib and object C:\Users\tomas\Repos\AgonesTestBuild\Plugins\Agones\Intermediate\Build\Win64\UnrealEditor\Development\Agones\UnrealEditor-Agones.exp
[12/14] Link UnrealEditor-AgonesTestBuild.dll
   Creating library C:\Users\tomas\Repos\AgonesTestBuild\Intermediate\Build\Win64\UnrealEditor\Development\AgonesTestBuild\UnrealEditor-AgonesTestBuild.suppressed.lib and object C:\Users\tomas\Repos\AgonesTestBuild\Intermediate\Build\Win64\UnrealEditor\Development\AgonesTestBuild\UnrealEditor-AgonesTestBuild.suppressed.exp
[13/14] Link UnrealEditor-Agones.dll
   Creating library C:\Users\tomas\Repos\AgonesTestBuild\Plugins\Agones\Intermediate\Build\Win64\UnrealEditor\Development\Agones\UnrealEditor-Agones.suppressed.lib and object C:\Users\tomas\Repos\AgonesTestBuild\Plugins\Agones\Intermediate\Build\Win64\UnrealEditor\Development\Agones\UnrealEditor-Agones.suppressed.exp
[14/14] WriteMetadata AgonesTestBuildEditor.target
Total time in Parallel executor: 37,97 seconds
Total execution time: 42,66 seconds
Rebuild succeeded at 11:43:45 AM 

@google-cla
Copy link

google-cla bot commented Dec 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 44f1261a-db42-407b-a550-487b2821f975

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2846/head:pr_2846 && git checkout pr_2846
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-984389e-amd64

@zmerlynn
Copy link
Collaborator

zmerlynn commented Dec 5, 2022

@YannickLange , @domgreen , @highlyunavailable , @dotcom - summoning as past Unreal contributors. Any issues?

@highlyunavailable
Copy link
Contributor

👍 LGTM!

@zmerlynn zmerlynn self-assigned this Dec 5, 2022
@google-oss-prow google-oss-prow bot added the lgtm label Dec 5, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Titantompa, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval by writing /assign @cyriltovena in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn
Copy link
Collaborator

zmerlynn commented Dec 5, 2022

Thanks, @highlyunavailable!

@zmerlynn zmerlynn merged commit a57d334 into googleforgames:main Dec 5, 2022
@markmandel markmandel added kind/bug These are bugs. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Dec 5, 2022
@mangalpalli mangalpalli added this to the 1.28.0 milestone Dec 6, 2022
chiayi pushed a commit to chiayi/agones that referenced this pull request Dec 13, 2022
…ror messages (googleforgames#2846)

* Added initialization of members in FDuration and FPlayerCapacity to avoid run-time warnings and errors

* Corrected the HTTP method of the SetPlayerCapacity to FHttpVerb::Put
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. lgtm size/XS
Projects
None yet
6 participants