Terraform, GKE - Option to create regional cluster as well as option to create autoscaling nodepool #2813

chiayi · 2022-11-15T00:55:16Z

What type of PR is this?
/kind bug

What this PR does / Why we need it:
It adds configuration to terraform so that regional clusters can be created.
It also added autoscaling option for default nodepools.

Which issue(s) this PR fixes:
Closes #1441
Closes #1467

Special notes for your reviewer:
I've also made changes to the README for /build to include the parameters.

agones-bot · 2022-11-15T01:24:34Z

Build Succeeded 👏

Build Id: 3751761c-f0ee-4470-9640-9fe9adb505b6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-deb17a1-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-deb17a1-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-deb17a1-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-deb17a1-amd64
Linux C++ SDK (build): agonessdk-1.28.0-deb17a1-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-deb17a1-amd64.zip

A preview of the website (the last 30 builds are retained):

https://deb17a1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-deb17a1-amd64

build/Makefile

zmerlynn · 2022-11-15T01:55:24Z

build/terraform/gke/module.tf

+  default     = ""
+  description = "The GCP location to create the cluster in"
+}
+


Should we just deprecate zone? IMO yes, but would like input from @roberthbailey. It would look like:

on new line 67, change the default to "us-west1-c"

on new line 72, change the default to ""

on new line 73, let's say "The GCP zone to create the cluster in (deprecated, use 'location')"

It looks like there is no formal deprecation procedure (hashicorp/terraform#18381) though, so I think to actually enforce the deprecation we'd have to add output to the module if zone were set.

WDYT?

I think the plan is to

make sure we keep things backwards compatible for at least 1 release and give folks a warning in the release notes that the variable name is changing.

So adding a deprecation note does follow that. But does this mean that zone would take precedence over location for the 1 release before being removed?

From the change I just made for this comment, GCP_CLUSTER_ZONE and GCP_CLUSTER_LOCATION will always be set. What would be the correct way to go about this?

GCP_CLUSTER_ZONE and GCP_CLUSTER_LOCATION are both set, but I think the change you just made to gcloud-terraform-install sets only location, right?

The logic is a little fussy, but I think we should check:

if location is set but not zone, use location (good path)

if zone is set but not location, use zone and warn (deprecated path)

if location and zone are set but equal, use either and warn.

if both are set, and not equal, throw an error

I'm not exactly sure how possible that is in .tf, but it seems like the right approach. If it's too much effort, though, holler.

I will add back zone to gcloud-terraform-install so that both variables will be available. As for adding warnings and errors, not sure if that is possible within the terraform files?

I don't think you need to add zone back in, I was pointing out that the Makefile is only sending the one - so there's no conflict between them.

Okay so I made it so that within the tf file, zone will be empty unless explicitly set. And it will only use zone if the variable is empty.

I didn't see this comment thread earlier but I think where you ended up looks good - we use location and we can add to the release notes that folks should switch their configs to use location but we continue to support zone for N releases (maybe 1, maybe a few) to give people time to migrate their configs.

We don't have a formal policy about compatibility of terraform configs (or helm for that matter) but we do try to do our best not to have knife edge changes that would break users upgrading across a single release.

build/includes/google-cloud.mk

zmerlynn · 2022-11-15T19:35:57Z

build/terraform/gke/module.tf

+  default     = ""
+  description = "The GCP location to create the cluster in"
+}
+


GCP_CLUSTER_ZONE and GCP_CLUSTER_LOCATION are both set, but I think the change you just made to gcloud-terraform-install sets only location, right?

The logic is a little fussy, but I think we should check:

if location is set but not zone, use location (good path)

if zone is set but not location, use zone and warn (deprecated path)

if location and zone are set but equal, use either and warn.

if both are set, and not equal, throw an error

I'm not exactly sure how possible that is in .tf, but it seems like the right approach. If it's too much effort, though, holler.

gongmax · 2022-11-16T00:15:34Z

I think it's better to also wire these options up to the example module and update the website page in case customer is following the instruction to create the cluster

agones-bot · 2022-11-16T00:41:45Z

Build Succeeded 👏

Build Id: 8292f534-0b3d-4939-a569-7254fab8137b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-31df389-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-31df389-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-31df389-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-31df389-amd64
Linux C++ SDK (build): agonessdk-1.28.0-31df389-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-31df389-amd64.zip

A preview of the website (the last 30 builds are retained):

https://31df389-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-31df389-amd64

agones-bot · 2022-11-16T00:52:40Z

Build Failed 😱

Build Id: 87ddce9a-8727-4a94-b492-2d6585e6919e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-11-16T01:10:13Z

Build Succeeded 👏

Build Id: 8d675391-e10e-49f9-babb-4fb855048b4e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-5c4a83b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-5c4a83b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-5c4a83b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-5c4a83b-amd64
Linux C++ SDK (build): agonessdk-1.28.0-5c4a83b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-5c4a83b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://5c4a83b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-5c4a83b-amd64

agones-bot · 2022-11-16T01:32:47Z

Build Succeeded 👏

Build Id: 53960b90-45ee-4cf1-908a-769d0ef30e3d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-855e0bc-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-855e0bc-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-855e0bc-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-855e0bc-amd64
Linux C++ SDK (build): agonessdk-1.28.0-855e0bc-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-855e0bc-amd64.zip

A preview of the website (the last 30 builds are retained):

https://855e0bc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-855e0bc-amd64

zmerlynn · 2022-11-16T02:28:51Z

install/terraform/modules/gke/cluster.tf

@@ -56,7 +60,7 @@ resource "null_resource" "test-setting-variables" {

 resource "google_container_cluster" "primary" {
  name       = local.name
-  location   = local.zone
+  location   = local.zone == "" ? local.location : local.zone


I would make this prioritize location.

It looks like warnings are not straightforward, so I think skipping that is fine. But at the very least, let's add an error if they're both non-empty and mismatched. I think it can be done like: https://medium.com/codex/terraform-variable-validation-b9b3e7eddd79

Later we can start erroring when zone is provided.

If we make the location a priority, do we still want location to have a default value? This would also effect the validation done on the variable.

As for cross variable validation, it's currently not supported but there seems to be hacky ways around it if we really need the check.

So zone no longer has a default and will only be used as the location if zone is not empty.

examples/terraform-submodules/gke/module.tf

gongmax · 2022-11-16T17:44:44Z

examples/terraform-submodules/gke/module.tf

@@ -53,9 +53,14 @@ variable "enable_image_streaming" {
  default = "true"
 }

-variable "zone" {


We also need to update the website page to indicate the change. Noted for changes to the website, we generally gate them so that they do not appear until the next release. Even though this doesn't require new features in Agones, it still makes sense to wait to publish this guidance until our next release.
https://agones.dev/site/docs/contribute/#within-a-page describes how to add the feature gate tags to the website pages.

Done! I think, not sure if I've done it correctly or not.

agones-bot · 2022-11-16T21:38:32Z

Build Succeeded 👏

Build Id: cc92fd64-99a6-420d-ba15-244bfb7a1b10

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-fd680de-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-fd680de-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-fd680de-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-fd680de-amd64
Linux C++ SDK (build): agonessdk-1.28.0-fd680de-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-fd680de-amd64.zip

A preview of the website (the last 30 builds are retained):

https://fd680de-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-fd680de-amd64

site/content/en/docs/Installation/Terraform/gke.md

zmerlynn · 2022-11-16T23:38:16Z

site/content/en/docs/Installation/Terraform/gke.md

@@ -96,6 +96,14 @@ Configurable parameters:
 - gameserver_maxPort - the upper bound of the port range which gameservers will listen on (default is "8000")
 - gameserver_namespaces - a list of namespaces which will be used to run gameservers (default is `["default"]`). For example `["default", "xbox-gameservers", "mobile-gameservers"]`
 - force_update - whether or not to force the replacement/update of resource (default is true, false may be required to prevent immutability errors when updating the configuration)
+{{% feature publishVersion="1.28" %}}


Probably should add another version-guarded section at line 90 to mention that zone is deprecated.

Added feature expiry to the zone. Not sure if this is the best way to do it.

agones-bot · 2022-11-17T00:12:29Z

Build Succeeded 👏

Build Id: c57fee7e-6da0-40e6-a275-34cf0327d970

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-4d41e67-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-4d41e67-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-4d41e67-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-4d41e67-amd64
Linux C++ SDK (build): agonessdk-1.28.0-4d41e67-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-4d41e67-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4d41e67-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-4d41e67-amd64

roberthbailey

I noticed while reviewing your change that in build/includes/terraform.mk there is a lot of duplication between the gcloud-terraform-cluster and gcloud-terraform-install targets. If you agree and think there would be a clean way to simplify them, that would be a good change for a follow-up PR.

roberthbailey · 2022-11-17T16:01:46Z

build/terraform/gke/module.tf

+  default     = ""
+  description = "The GCP location to create the cluster in"
+}
+


I didn't see this comment thread earlier but I think where you ended up looks good - we use location and we can add to the release notes that folks should switch their configs to use location but we continue to support zone for N releases (maybe 1, maybe a few) to give people time to migrate their configs.

We don't have a formal policy about compatibility of terraform configs (or helm for that matter) but we do try to do our best not to have knife edge changes that would break users upgrading across a single release.

roberthbailey · 2022-11-17T16:03:15Z

install/terraform/modules/gke/variables.tf

@@ -30,7 +30,8 @@ variable "cluster" {
  type        = map

  default = {
-    "zone"                    = "us-west1-c"
+    "location"		      = "us-west1-c"
+    "zone"                    = ""


Should we remove zone from here to only have location in our sample configs?

I think we can. There isn't really a reason to have zone here anymore.

agones-bot · 2022-11-17T18:56:05Z

Build Succeeded 👏

Build Id: 7742b8c1-88bd-416e-b68d-bd033161b5be

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-ba32d44-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-ba32d44-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-ba32d44-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-ba32d44-amd64
Linux C++ SDK (build): agonessdk-1.28.0-ba32d44-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-ba32d44-amd64.zip

A preview of the website (the last 30 builds are retained):

https://ba32d44-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-ba32d44-amd64

agones-bot · 2022-11-17T20:37:38Z

Build Succeeded 👏

Build Id: ebe142e8-7f35-4faa-9d51-d17e206e7cc9

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-6362582-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-6362582-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-6362582-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-6362582-amd64
Linux C++ SDK (build): agonessdk-1.28.0-6362582-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-6362582-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6362582-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-6362582-amd64

agones-bot · 2022-11-17T20:56:51Z

Build Succeeded 👏

Build Id: 004ee176-1a2a-4d56-9de1-244138d6856d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-ba32d44-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-ba32d44-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-ba32d44-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-ba32d44-amd64
Linux C++ SDK (build): agonessdk-1.28.0-ba32d44-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-ba32d44-amd64.zip

A preview of the website (the last 30 builds are retained):

https://ba32d44-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-ba32d44-amd64

agones-bot · 2022-11-17T21:12:13Z

Build Succeeded 👏

Build Id: aa55b7a1-9a91-4058-8d94-cb8b9b5c8dcc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-367b52e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-367b52e-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-367b52e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-367b52e-amd64
Linux C++ SDK (build): agonessdk-1.28.0-367b52e-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-367b52e-amd64.zip

A preview of the website (the last 30 builds are retained):

https://367b52e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-367b52e-amd64

* Makefile changes for adding location variable * added autoscale parameters to Makefile and README * Markdown fix in readme * Changed LOCATION to always be set with ZONE as default * use only if the variable has a value * fixed extraneous characters * update gke terraform exmaple module * Added autoscale to example cluster and added to website docs * Added defaults and feature expiry * Remove zone from gke/variable.tf file.

agones-bot · 2022-11-17T22:59:26Z

Build Succeeded 👏

Build Id: 6ff6b1e1-43cd-46b8-90d4-83c929dee02b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-4892725-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-4892725-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-4892725-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-4892725-amd64
Linux C++ SDK (build): agonessdk-1.28.0-4892725-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-4892725-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4892725-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2813/head:pr_2813 && git checkout pr_2813
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-4892725-amd64

google-oss-prow · 2022-11-18T09:49:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiayi, gongmax, roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow bot requested review from aLekSer and markmandel November 15, 2022 00:55

google-oss-prow bot added the size/M label Nov 15, 2022

zmerlynn requested changes Nov 15, 2022

View reviewed changes

google-oss-prow bot assigned zmerlynn Nov 15, 2022

zmerlynn reviewed Nov 15, 2022

View reviewed changes

zmerlynn reviewed Nov 16, 2022

View reviewed changes

gongmax reviewed Nov 16, 2022

View reviewed changes

examples/terraform-submodules/gke/module.tf Show resolved Hide resolved

gongmax reviewed Nov 16, 2022

View reviewed changes

google-oss-prow bot added size/L and removed size/M labels Nov 16, 2022

gongmax reviewed Nov 16, 2022

View reviewed changes

site/content/en/docs/Installation/Terraform/gke.md Outdated Show resolved Hide resolved

zmerlynn reviewed Nov 16, 2022

View reviewed changes

zmerlynn approved these changes Nov 16, 2022

View reviewed changes

google-oss-prow bot added lgtm and removed lgtm labels Nov 16, 2022

gongmax approved these changes Nov 16, 2022

View reviewed changes

google-oss-prow bot assigned gongmax Nov 16, 2022

google-oss-prow bot added the lgtm label Nov 16, 2022

roberthbailey reviewed Nov 17, 2022

View reviewed changes

google-oss-prow bot removed the lgtm label Nov 17, 2022

roberthbailey approved these changes Nov 17, 2022

View reviewed changes

google-oss-prow bot assigned roberthbailey Nov 17, 2022

google-oss-prow bot added lgtm approved labels Nov 17, 2022

chiayi force-pushed the main branch from ba32d44 to 6362582 Compare November 17, 2022 20:10

google-oss-prow bot added size/XXL and removed lgtm size/L labels Nov 17, 2022

chiayi force-pushed the main branch from 6362582 to ba32d44 Compare November 17, 2022 20:26

google-oss-prow bot added size/L and removed size/XXL labels Nov 17, 2022

chiayi force-pushed the main branch from ba32d44 to 367b52e Compare November 17, 2022 20:29

google-oss-prow bot added size/XXL and removed size/L labels Nov 17, 2022

chiayi force-pushed the main branch from 367b52e to 4892725 Compare November 17, 2022 22:30

google-oss-prow bot added size/L and removed size/XXL labels Nov 17, 2022

roberthbailey approved these changes Nov 18, 2022

View reviewed changes

google-oss-prow bot added the lgtm label Nov 18, 2022

roberthbailey merged commit e3cb2a4 into googleforgames:main Nov 18, 2022

mangalpalli added this to the 1.28.0 milestone Nov 29, 2022

zmerlynn mentioned this pull request Nov 29, 2022

Request for zmerlynn to become Approver #2833

Closed

5 tasks

gongmax mentioned this pull request Nov 29, 2022

Request for gongmax to become Approver #2834

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terraform, GKE - Option to create regional cluster as well as option to create autoscaling nodepool #2813

Terraform, GKE - Option to create regional cluster as well as option to create autoscaling nodepool #2813

chiayi commented Nov 15, 2022

agones-bot commented Nov 15, 2022

zmerlynn Nov 15, 2022

chiayi Nov 15, 2022

chiayi Nov 15, 2022

zmerlynn Nov 15, 2022

chiayi Nov 15, 2022

zmerlynn Nov 15, 2022

chiayi Nov 16, 2022

roberthbailey Nov 17, 2022

zmerlynn Nov 15, 2022

gongmax commented Nov 16, 2022

agones-bot commented Nov 16, 2022

agones-bot commented Nov 16, 2022

agones-bot commented Nov 16, 2022

agones-bot commented Nov 16, 2022

zmerlynn Nov 16, 2022

chiayi Nov 16, 2022

chiayi Nov 16, 2022

gongmax Nov 16, 2022

chiayi Nov 16, 2022 •

edited

Loading

agones-bot commented Nov 16, 2022

zmerlynn Nov 16, 2022

chiayi Nov 16, 2022

agones-bot commented Nov 17, 2022

roberthbailey left a comment

roberthbailey Nov 17, 2022

roberthbailey Nov 17, 2022

chiayi Nov 17, 2022

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

google-oss-prow bot commented Nov 18, 2022

Terraform, GKE - Option to create regional cluster as well as option to create autoscaling nodepool #2813

Terraform, GKE - Option to create regional cluster as well as option to create autoscaling nodepool #2813

Conversation

chiayi commented Nov 15, 2022

agones-bot commented Nov 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gongmax commented Nov 16, 2022

agones-bot commented Nov 16, 2022

agones-bot commented Nov 16, 2022

agones-bot commented Nov 16, 2022

agones-bot commented Nov 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chiayi Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Nov 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 17, 2022

roberthbailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

agones-bot commented Nov 17, 2022

google-oss-prow bot commented Nov 18, 2022

chiayi Nov 16, 2022 •

edited

Loading