Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.27.0-rc #2768

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Conversation

mangalpalli
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind release

What this PR does / Why we need it:
This includes all the changes for the 1.27.0 release candidate, as wel as several improvements to the release checklist and templated

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

NA

@mangalpalli mangalpalli added the kind/release Checklist for a release label Oct 19, 2022
@mangalpalli mangalpalli added this to the 1.27.0 milestone Oct 19, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: af548b53-24a7-4a31-bceb-32519e79a777

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@mangalpalli mangalpalli requested review from markmandel and removed request for markmandel, steven-supersolid and roberthbailey October 19, 2022 16:21
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e00bf7f5-0f4d-47e0-b448-80d29cb9fdd0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Looking at the output:

make[1]: Leaving directory '/workspace/build'
sort /workspace/install/yaml/install.yaml > /tmp/agones-install/install.current.yaml.sorted
make: *** [Makefile:340: test-install-yaml] Error 1
make: *** Waiting for unfinished jobs....
diff /tmp/agones-install/install.yaml.sorted /tmp/agones-install/install.current.yaml.sorted
13958c13958
<           image: "gcr.io/agones-images/agones-ping:1.27.0-dev"
---
>           image: "gcr.io/agones-images/agones-ping:1.27.0-rc"
14068c14068
<           value: "gcr.io/agones-images/agones-sdk:1.27.0-dev"
---
>           value: "gcr.io/agones-images/agones-sdk:1.27.0-rc"
14180,14181c14180,14181
<         image: "gcr.io/agones-images/agones-allocator:1.27.0-dev"
<         image: "gcr.io/agones-images/agones-controller:1.27.0-dev"
---
>         image: "gcr.io/agones-images/agones-allocator:1.27.0-rc"
>         image: "gcr.io/agones-images/agones-controller:1.27.0-rc"

Looks like you missed make gen-install or ran it before making the changes to all the helm variables.

linkTitle: "1.27.0-rc"
date: "2022-10-18"
---
This is the 1.27.0-rc release of Agones.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing quite a few formatting items from the template: https://raw.githubusercontent.com/googleforgames/agones/main/docs/governance/templates/release.md

Not sure where they went? Maybe start from a copy/paste of the clean template and fill in all the missing items?

When updating this PR, please also make sure the Github Release draft also matches.

site/content/en/blog/releases/1.27.0-rc.md Outdated Show resolved Hide resolved

This release brings us support for Kubernetes 1.23, so if you are installing this release, remember to upgrade your clusters.

Check the README for details on features, installation and usage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link has gone from this line?


Check the README for details on features, installation and usage.

Implemented enhancements:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be bold.

site/content/en/blog/releases/1.27.0-rc.md Outdated Show resolved Hide resolved
site/content/en/blog/releases/1.27.0-rc.md Show resolved Hide resolved
site/content/en/blog/releases/1.27.0-rc.md Outdated Show resolved Hide resolved
site/content/en/blog/releases/1.27.0-rc.md Outdated Show resolved Hide resolved

Helm chart available with this release:

helm install agones agones/agones --version {version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing links and list formatting

site/content/en/blog/releases/1.27.0-rc.md Outdated Show resolved Hide resolved
@roberthbailey
Copy link
Member

https://raw.githubusercontent.com/googleforgames/agones/main/site/content/en/blog/releases/1.26.0.md should be updated as part of this PR to remove the three occurrences of data-proofer-ignore now that the release has been finalized.

- An example of setting autoscaler behavior in a Fleet.
- Log cleanup for pods not yet running

Check the <a href="https://github.com/googleforgames/agones/tree/release-1.27.0-rc">README</a> for details on features, installation and usage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without data-proofer-ignore this is going to fail. See the template: https://raw.githubusercontent.com/googleforgames/agones/main/docs/governance/templates/release.md

- Support Agones on ARM systems [\#2216](https://github.com/googleforgames/agones/issues/2216)
- Update example containers to fix security vulnerabilities [\#1154](https://github.com/googleforgames/agones/issues/1154)

**Fixed bugs:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs, closed issues and merged PRs should be removed. Per the template:

insert enhancements from the changelog and/or security and breaking changes

Documentation: https://development.agones.dev/site/


See <a href="https://github.com/googleforgames/agones/blob/release-1.27.0-rc/CHANGELOG.md">CHANGELOG</a> for more details on changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without data-proofer-ignore this is going to fail. See the template: https://raw.githubusercontent.com/googleforgames/agones/main/docs/governance/templates/release.md

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0bb80aa5-2a5e-4359-aada-305f3eb4863b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4ba134ec-e756-4dce-ab63-65d70bd81b77

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7d1c9acf-d0c8-4ac6-8b93-25575d64ba8d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 68aa899b-d4c6-4446-8698-7fd089a08bef

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: da178058-d52a-47f9-9145-5ba889d5652e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2768/head:pr_2768 && git checkout pr_2768
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-3001987-amd64

@markmandel
Copy link
Member

This looks good to me! Will approve and merge tomorrow morning so we can move on to the next steps (since when we merge, the changes to the website will also go live).

- [gcr.io/agones-images/agones-controller:1.27.0-rc](https://gcr.io/agones-images/agones-controller:1.27.0-rc)
- [gcr.io/agones-images/agones-sdk:1.27.0-rc](https://gcr.io/agones-images/agones-sdk:1.27.0-rc)
- [gcr.io/agones-images/agones-ping:1.27.0-rc](https://gcr.io/agones-images/agones-ping:1.27.0-rc)
- [gcr.io/agones-images/agones-allocator:{1.27.0-rc](https://gcr.io/agones-images/agones-allocator:1.27.0-rc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra { left in this line. It should be gcr.io/agones-images/agones-allocator:1.27.0-rc

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cdc6fdcc-9c33-4795-857a-3e1162ef1254

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2768/head:pr_2768 && git checkout pr_2768
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-5d745af-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge when succeeded.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangalpalli, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit c34207b into googleforgames:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants