Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2665 Log cleanup: Verbose error log on pod not yet running #2763

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

mangalpalli
Copy link
Contributor

@mangalpalli mangalpalli commented Oct 13, 2022

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
Wrapping this returned error in a: agones/pkg/util/workerqueue/workerqueue.go will resolve it.

Which issue(s) this PR fixes:
we were noticing this in the logs: agones/pkg/gameservers/controller.go
return nil, fmt.Errorf("game server container for GameServer %s in namespace %s is not currently running, try again", gsCopy.ObjectMeta.Name, gsCopy.ObjectMeta.Namespace)

Closes #2665

Special notes for your reviewer:

@google-cla
Copy link

google-cla bot commented Oct 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9f504345-2ba0-4e55-a1d8-6a3d449dbb39

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@mangalpalli mangalpalli added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 13, 2022
@mangalpalli mangalpalli self-assigned this Oct 13, 2022
@gongmax
Copy link
Collaborator

gongmax commented Oct 13, 2022

nit: better to add the corresponding issue link to the PR description. i.e. Closes #2665
Please follow the instruction to get CLA so the check can pass.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangalpalli, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: abd4da91-7315-4fec-bf94-fd151e48fd5b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2763/head:pr_2763 && git checkout pr_2763
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-7a00fc3-amd64

@markmandel markmandel merged commit 83e4b27 into main Oct 13, 2022
@markmandel markmandel deleted the 2665-ravi-debug-log branch October 13, 2022 19:48
@mangalpalli mangalpalli added this to the 1.27.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log cleanup: Verbose error log on pod not yet running
4 participants