Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre release check for RC #2719

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

SaitejaTamma
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@SaitejaTamma SaitejaTamma added the kind/documentation Documentation for Agones label Aug 25, 2022
@SaitejaTamma SaitejaTamma added this to the 1.26.0 milestone Aug 25, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4ee940d1-eb55-419b-82e4-645c4ccdd374

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2719/head:pr_2719 && git checkout pr_2719
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-eb5a61e-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 521463cd-a4dd-45f3-88cf-d6f8e71295d4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

That's a new flake:

--- FAIL: TestDevelopmentGameServerLifecycle (18.61s)
    gameserver_test.go:483: 
        	Error Trace:	gameserver_test.go:483
        	Error:      	Not equal: 
        	            	expected: "udp-server78pb4"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-udp-server78pb4
        	            	+
        	Test:       	TestDevelopmentGameServerLifecycle

e2e-feature-gates

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, SaitejaTamma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4c7ca895-51a4-4fe8-bcab-a2c495c3e240

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2719/head:pr_2719 && git checkout pr_2719
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-2afd0bd-amd64

@markmandel markmandel merged commit b7849ef into googleforgames:main Aug 29, 2022
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/meta Organisational matters. e.g. Governance, release cycles, etc. labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants