Bug: make install uses local helm and jq
#2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a difference between " and ', meant that the `make install` command that would check the helm install and uninstall if necessary was actually using the local installations of `helm` and `jq` rather than the ones in the Docker container. This didn't fail in most places, as Cloud Build, and many of our dev machines have these installed already, and the command is set to be ignored if it fails for whatever reason (as a safety measure). I only noticed the output on screen when helping a teammate debug some other issues.
markmandel
added
kind/bug
roberthbailey
approved these changes
Jul 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
In a difference between " and ', meant that the
make installcommand that would check the helm install and uninstall if necessary was actually using the local installations ofhelmandjqrather than the ones in the Docker container.This didn't fail in most places, as Cloud Build, and many of our dev machines have these installed already, and the command is set to be ignored if it fails for whatever reason (as a safety measure).
I only noticed the output on screen when helping a teammate debug some other issues.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A