Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeExternalDNS/stable #2660

Merged

Conversation

SaitejaTamma
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2643

Special notes for your reviewer:

@SaitejaTamma SaitejaTamma added the kind/feature New features for Agones label Jul 6, 2022
@SaitejaTamma SaitejaTamma requested a review from markmandel July 6, 2022 19:13
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2de77396-a01e-4de3-bab7-b8f1f2ab9b8c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2660/head:pr_2660 && git checkout pr_2660
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-920a115-amd64

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 8, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, SaitejaTamma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 347faccd-b3a5-4f4f-a768-481b8d4be371

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2660/head:pr_2660 && git checkout pr_2660
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-3f3d99e-amd64

@markmandel markmandel merged commit 7492d86 into googleforgames:main Jul 8, 2022
@SaitejaTamma SaitejaTamma added this to the 1.25.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move NodeExternalDNS to stable
3 participants