Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install docs: Supported Container Architectures #2621

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Added a section in the installation docs where we specify the supported cluster requirements. Now we're supporting multiple OS's and architectures at different levels, I've added a table to indicate each of the levels, so that users are aware.

Which issue(s) this PR fixes:

Work on #2216

Special notes for your reviewer:

I didn't keep arm64 for the past release, since we know the controller is broken for 1.23.0.

As part of this work, I moved the note on node pools into its own "best practices" section.

Added a section in the installation docs where we specify the
supported cluster requirements. Now we're supporting multiple OS's and
architectures at different levels, I've added a table to indicate each
of the levels, so that users are aware.

I didn't keep arm64 for the past release, since we know the controller
is broken for 1.23.0.

As part of this work, I moved the note on node pools into its own
"best practices" section.

Work on googleforgames#2216
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 9, 2022
@markmandel markmandel added this to the 1.24.0 milestone Jun 9, 2022
@markmandel markmandel requested a review from roberthbailey June 9, 2022 23:03
@google-oss-prow google-oss-prow bot requested review from aLekSer and dzlier-gcp June 9, 2022 23:03
@markmandel
Copy link
Member Author

Screenshot of changes.

screen

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e3dbc32c-721e-412c-a9e0-96902c3f2d9b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2621/head:pr_2621 && git checkout pr_2621
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-5c75c11-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label Jun 10, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9aed3f1a-5d29-4245-a617-f0cecf8d2fc9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2621/head:pr_2621 && git checkout pr_2621
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-24d30ca-amd64

@roberthbailey roberthbailey merged commit 0998cde into googleforgames:main Jun 10, 2022
@markmandel markmandel deleted the docs/architectures branch June 10, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants