Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade built-tools Prometheus and Grafana #2618

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

The old versions of Grafana where using K8s beta apis, so now would no longer install, so figured I would update both to the current latest.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

The old versions of Grafana where using K8s beta apis, so now would no
longer install, so figured I would update both to the current latest.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jun 8, 2022
@markmandel markmandel requested a review from roberthbailey June 8, 2022 17:42
@google-oss-prow google-oss-prow bot requested a review from cyriltovena June 8, 2022 17:42
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e9391eb4-cdac-4ff1-bb54-ae5bea4976ba

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 72c9652d-1cad-405d-9c09-bc6c3566c3f8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2618/head:pr_2618 && git checkout pr_2618
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-9fbf0a2-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Jun 9, 2022
@roberthbailey roberthbailey merged commit a7a9097 into googleforgames:main Jun 9, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel deleted the cleanup/upgrade-prom-graf branch June 9, 2022 16:59
@SaitejaTamma SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants