Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for number of reserved replicas #2610

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Add metric for number of reserved replicas #2610

merged 1 commit into from
Jun 6, 2022

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Jun 6, 2022

What type of PR is this?

/kind feature

What this PR does / Why we need it:

The current metrics for fleets include total game servers, allocated game servers, ready game servers, and desired game servers, however, doesn't include reserved game servers.
This PR adds the count metrics for reserved game servers.

Which issue(s) this PR fixes:

Closes #2609

Special notes for your reviewer:
None

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fe3a4987-36f6-4963-a010-c8be12e2ca73

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2610/head:pr_2610 && git checkout pr_2610
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-d422929-amd64

@govargo
Copy link
Contributor Author

govargo commented Jun 6, 2022

I added to unit test and tried on GKE cluster with reserved game server.

Here is the screenshot of Prometheus graph(type=reserved).
スクリーンショット 2022-06-06 18 58 33

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rcreasey
Copy link
Collaborator

rcreasey commented Jun 6, 2022

Looks great! Thanks for knocking this out!

@roberthbailey roberthbailey merged commit fd64401 into googleforgames:main Jun 6, 2022
@govargo govargo deleted the add-metrics-reserved branch June 7, 2022 04:12
@SaitejaTamma SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022
@SaitejaTamma SaitejaTamma added the kind/feature New features for Agones label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metric for number of reserved replicas in a fleet
5 participants