-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build command: build-agones-sdk-image #2603
Fix build command: build-agones-sdk-image #2603
Conversation
You save my day ! I'm on it since 2h -_-' |
Build Failed 😱 Build Id: 309caa33-c7f2-4419-a680-3fd13ebed9db To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: govargo, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: govargo, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: f7697487-c5bd-4b40-9c76-10cf09a5248a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
I found that agones-sdk image build command failed when I tried to test
make run-sdk-conformance-test
.The command has changed, but it seems to have leaked in #2521.
Before this PR
BUILD_TARGET=build-agones-sdk-server-image
is defined, but it doesn't exist.The correct one is
build-agones-sdk-image
.After this PR
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: