-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use source sdk in simple-game-server #2527
Use source sdk in simple-game-server #2527
Conversation
Fixes issue identified in googleforgames#2503 (comment) Wherein the simple game server was no longer grabbing the sdk from source but instead the latest release.
Build Succeeded 👏 Build Id: 41f71312-99e2-40b8-868c-b69cd7e06487 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This doesn't seem urgent so I think we should hold it until after the release on Monday. |
I agree |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 04755337-14c4-469b-9f2e-1105b1c1f5a3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Fixes issue identified in googleforgames#2503 (comment) Wherein the simple game server was no longer grabbing the sdk from source but instead the latest release. Co-authored-by: Robert Bailey <[email protected]>
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Wherein the simple game server was no longer grabbing the sdk from
source but instead the latest release.
Which issue(s) this PR fixes:
Fixes issue identified in
#2503 (comment)
Special notes for your reviewer:
I'll bump the e2e test to 0.12 once this has merged.