Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use source sdk in simple-game-server #2527

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Wherein the simple game server was no longer grabbing the sdk from
source but instead the latest release.

Which issue(s) this PR fixes:

Fixes issue identified in
#2503 (comment)

Special notes for your reviewer:

I'll bump the e2e test to 0.12 once this has merged.

Fixes issue identified in
googleforgames#2503 (comment)

Wherein the simple game server was no longer grabbing the sdk from
source but instead the latest release.
@markmandel markmandel added kind/bug These are bugs. area/examples Examples. Usually found in the `examples` directory labels Apr 1, 2022
@markmandel markmandel requested a review from roberthbailey April 1, 2022 03:25
@google-oss-prow google-oss-prow bot requested review from aLekSer and pooneh-m April 1, 2022 03:25
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 41f71312-99e2-40b8-868c-b69cd7e06487

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2527/head:pr_2527 && git checkout pr_2527
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-312eaf5

@roberthbailey
Copy link
Member

This doesn't seem urgent so I think we should hold it until after the release on Monday.

@markmandel
Copy link
Member Author

I agree

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 1, 2022
@SaitejaTamma SaitejaTamma removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 5, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 04755337-14c4-469b-9f2e-1105b1c1f5a3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2527/head:pr_2527 && git checkout pr_2527
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-ef1e6c6

@roberthbailey roberthbailey merged commit 7cb0083 into googleforgames:main Apr 7, 2022
@markmandel markmandel deleted the examples/simple-udp-0.12 branch April 7, 2022 22:01
Thiryn pushed a commit to Thiryn/agones that referenced this pull request Apr 25, 2022
Fixes issue identified in
googleforgames#2503 (comment)

Wherein the simple game server was no longer grabbing the sdk from
source but instead the latest release.

Co-authored-by: Robert Bailey <[email protected]>
@SaitejaTamma SaitejaTamma added this to the 1.23.0 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory kind/bug These are bugs. lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants