Add Allocation Endpoint GCP solution for multi-cluster allocation to Agones examples #2499

pooneh-m · 2022-02-28T20:29:20Z

What type of PR is this?
/kind documentation
/kind feature

What this PR does / Why we need it:

This is an example solution to leverage GCP for creating a proxy server that redirects game server allocation requests to the backend Agones clusters.

Using this solution:

A Cloud Run instance is created and its URL is exposed as the allocation endpoint. Matchmaker sends allocation requests to this endpoint.
Agones clusters can be added and removed using Cloud Run environment variables without any change to the caller of allocation endpoint (matchmaker)
The solution leverages the GCP service account and removes the need for mTLS and client certificate management. It is compatible with Workload Identity.

Which issue(s) this PR fixes:

Closes # #2495

Special notes for your reviewer:

agones-bot · 2022-02-28T20:59:24Z

Build Failed 😱

Build Id: a708ab1d-e58b-4365-8277-4bd1f77078b6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2022-02-28T21:08:23Z

Doesn't look like your fault, some 404's on aws autoscaling examples

site/docs/advanced/scheduling-and-autoscaling/index.html
  Non-OK status: 404 --- site/docs/advanced/scheduling-and-autoscaling/index.html --> https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/autoscaling.md
  Non-OK status: 404 --- site/docs/advanced/scheduling-and-autoscaling/index.html --> https://github.com/terraform-aws-modules/terraform-aws-eks/tree/master/examples/irsa

roberthbailey

All of the files need to have the license header at the top.

examples/allocation-endpoint/README.md

examples/allocation-endpoint/server/clusterselector.go

examples/allocation-endpoint/server/main.go

agones-bot · 2022-02-28T22:42:43Z

Build Succeeded 👏

Build Id: 00c5374a-27ea-4489-8ea0-4471944fe0f6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-6172a51
image: gcr.io/agones-images/agones-ping:1.22.0-6172a51
Linux C++ SDK (build): agonessdk-1.22.0-6172a51-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-6172a51.zip

A preview of the website (the last 30 builds are retained):

https://6172a51-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-6172a51

ilkercelikyilmaz

I left one comment. PTAL

examples/allocation-endpoint/client/main.go

pooneh-m

Thanks for the review.

examples/allocation-endpoint/README.md

pooneh-m · 2022-03-01T21:26:43Z

examples/allocation-endpoint/README.md

+  The `name` is a unique randomly selected name for the cluster. 
+  The `endpoint` is the `agones-allocator` external IP. 
+  The `namespace` is the game server namespace.  
+  The `allocation_weight` is a value between 0 and 100, which sets the relative allocation rate a cluster receives compared to other clusters. By setting weight to zero, a cluster stops receiving allocation requests.


Good catch. Thanks.

examples/allocation-endpoint/README.md

pooneh-m · 2022-03-01T21:27:42Z

examples/allocation-endpoint/README.md

+
+```
+docker build --tag gcr.io/[PROJECT-ID]/allocation-endpoint-proxy .
+docker push gcr.io/[PROJECT-ID]/allocation-endpoint-proxy


We should do that for agones-images, but this is for the users and they can either use latest as the default or version it.

examples/allocation-endpoint/client/main.go

agones-bot · 2022-03-01T22:55:20Z

Build Failed 😱

Build Id: 30b500f4-f980-4266-a811-84988b483ae7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2022-03-01T23:34:56Z

@pooneh-m I have a feeling your main branch which this work is based on isn't up to date, since the two failures you've had have since been fixed. Can you double check your branch is up to date with upstream/main please?

examples/allocation-endpoint/README.md

examples/allocation-endpoint/server/Dockerfile

pooneh-m · 2022-03-02T07:39:27Z

@pooneh-m I have a feeling your main branch which this work is based on isn't up to date, since the two failures you've had have since been fixed. Can you double check your branch is up to date with upstream/main please?

My bad. It should be synced now.

agones-bot · 2022-03-02T08:01:03Z

Build Succeeded 👏

Build Id: 6cf0ad6e-5e71-4418-b30a-d792f464ba51

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-a98654d
image: gcr.io/agones-images/agones-ping:1.22.0-a98654d
Linux C++ SDK (build): agonessdk-1.22.0-a98654d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-a98654d.zip

A preview of the website (the last 30 builds are retained):

https://a98654d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-a98654d

agones-bot · 2022-03-02T23:08:18Z

Build Succeeded 👏

Build Id: 08ae76a5-c1bc-455d-91e9-06557bceecb3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-9f3929f
image: gcr.io/agones-images/agones-ping:1.22.0-9f3929f
Linux C++ SDK (build): agonessdk-1.22.0-9f3929f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-9f3929f.zip

A preview of the website (the last 30 builds are retained):

https://9f3929f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-9f3929f

roberthbailey

LGTM!

examples/allocation-endpoint/terraform/api_config.yaml.tpl

agones-bot · 2022-03-06T06:18:40Z

Build Succeeded 👏

Build Id: 40e9487f-3346-4c5a-8cef-05f40bd1a02d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-a14123f
image: gcr.io/agones-images/agones-ping:1.22.0-a14123f
Linux C++ SDK (build): agonessdk-1.22.0-a14123f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-a14123f.zip

A preview of the website (the last 30 builds are retained):

https://a14123f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-a14123f

roberthbailey

Thanks for the updates. LGTM!

examples/allocation-endpoint/README.md

markmandel · 2022-03-07T21:25:44Z

Just making a note down here, so it doesn't get lost. If Robby has gone through everything, then I'm happy 👍🏻

The only thing I would like to see is if we are shipping a container as part of the examples, then we should have this be integrated with both make test-examples-on-gcr (examples.mk) for testing that the image version exists at release time, and also make release-example-image-markdown to add the example image to the release markdown as well (release.mk).

…Agoens examples

agones-bot · 2022-03-08T07:55:28Z

Build Succeeded 👏

Build Id: 37803814-2fac-40c0-8aca-cd3cd7287003

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-eb24ad3
image: gcr.io/agones-images/agones-ping:1.22.0-eb24ad3
Linux C++ SDK (build): agonessdk-1.22.0-eb24ad3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-eb24ad3.zip

A preview of the website (the last 30 builds are retained):

https://eb24ad3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-eb24ad3

agones-bot · 2022-03-08T08:02:15Z

Build Succeeded 👏

Build Id: 55c4a082-a5af-4ede-a443-629714534c80

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-9e3b548
image: gcr.io/agones-images/agones-ping:1.22.0-9e3b548
Linux C++ SDK (build): agonessdk-1.22.0-9e3b548-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-9e3b548.zip

A preview of the website (the last 30 builds are retained):

https://9e3b548-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-9e3b548

roberthbailey

Thanks for adding the makefile changes. I left a few comments on them.

build/includes/examples.mk

examples/allocation-endpoint/Makefile

examples/allocation-endpoint/README.md

examples/allocation-endpoint/Makefile

google-oss-prow · 2022-03-08T19:09:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cindy52, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2022-03-08T19:09:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cindy52, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2022-03-08T19:36:18Z

Build Succeeded 👏

Build Id: db1c1ab7-7445-425e-b4cf-b2009564ddfb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-2dc7bae
image: gcr.io/agones-images/agones-ping:1.22.0-2dc7bae
Linux C++ SDK (build): agonessdk-1.22.0-2dc7bae-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-2dc7bae.zip

A preview of the website (the last 30 builds are retained):

https://2dc7bae-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-2dc7bae

agones-bot · 2022-03-08T19:44:42Z

Build Succeeded 👏

Build Id: 01767487-214a-4991-b9fe-aae36c7e1f4a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.22.0-e379d12
image: gcr.io/agones-images/agones-ping:1.22.0-e379d12
Linux C++ SDK (build): agonessdk-1.22.0-e379d12-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.22.0-e379d12.zip

A preview of the website (the last 30 builds are retained):

https://e379d12-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2499/head:pr_2499 && git checkout pr_2499
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-e379d12

google-oss-prow bot requested review from cyriltovena and roberthbailey February 28, 2022 20:29

google-oss-prow bot added approved size/XXL labels Feb 28, 2022

pooneh-m requested review from cindy52 and markmandel and removed request for cyriltovena February 28, 2022 20:29

roberthbailey changed the title ~~Add Allocation Endpoint GCP solution for multi-cluster allocation to Agoens examples~~ Add Allocation Endpoint GCP solution for multi-cluster allocation to Agones examples Feb 28, 2022

roberthbailey mentioned this pull request Feb 28, 2022

Invalid warnings when using multi-cluster allocation #2498

Closed

roberthbailey reviewed Feb 28, 2022

View reviewed changes

ilkercelikyilmaz previously requested changes Feb 28, 2022

View reviewed changes

examples/allocation-endpoint/client/main.go Show resolved Hide resolved

google-oss-prow bot assigned ilkercelikyilmaz Feb 28, 2022

pooneh-m force-pushed the master branch from 6172a51 to dbf32ac Compare March 1, 2022 22:45

pooneh-m commented Mar 1, 2022

View reviewed changes

cindy52 reviewed Mar 2, 2022

View reviewed changes

examples/allocation-endpoint/README.md Show resolved Hide resolved

examples/allocation-endpoint/server/Dockerfile Show resolved Hide resolved

pooneh-m force-pushed the master branch from dbf32ac to a98654d Compare March 2, 2022 07:37

pooneh-m requested review from roberthbailey, ilkercelikyilmaz and cindy52 March 2, 2022 22:43

roberthbailey approved these changes Mar 3, 2022

View reviewed changes

examples/allocation-endpoint/terraform/api_config.yaml.tpl Outdated Show resolved Hide resolved

google-oss-prow bot assigned roberthbailey Mar 3, 2022

google-oss-prow bot added the lgtm label Mar 3, 2022

google-oss-prow bot added the lgtm label Mar 5, 2022

pooneh-m force-pushed the master branch from 471a0f5 to a14123f Compare March 6, 2022 05:52

google-oss-prow bot removed the lgtm label Mar 6, 2022

roberthbailey approved these changes Mar 6, 2022

View reviewed changes

google-oss-prow bot added the lgtm label Mar 6, 2022

markmandel reviewed Mar 7, 2022

View reviewed changes

examples/allocation-endpoint/README.md Show resolved Hide resolved

pooneh-m added 3 commits March 8, 2022 07:18

Add Allocation Endpoint GCP solution for multi-cluster allocation to …

32aa9b5

…Agoens examples

Add label to the Allocation Endpoint Proxy

8f326a6

Addressed feedback on doc

57d51b0

pooneh-m force-pushed the master branch from a14123f to 9e3b548 Compare March 8, 2022 07:19

google-oss-prow bot removed the lgtm label Mar 8, 2022

pooneh-m force-pushed the master branch from 9e3b548 to eb24ad3 Compare March 8, 2022 07:21

roberthbailey reviewed Mar 8, 2022

View reviewed changes

build/includes/examples.mk Show resolved Hide resolved

examples/allocation-endpoint/Makefile Outdated Show resolved Hide resolved

examples/allocation-endpoint/README.md Show resolved Hide resolved

examples/allocation-endpoint/Makefile Show resolved Hide resolved

pooneh-m force-pushed the master branch from eb24ad3 to e379d12 Compare March 8, 2022 19:02

Adding make files

2dc7bae

pooneh-m force-pushed the master branch from e379d12 to 2dc7bae Compare March 8, 2022 19:08

roberthbailey approved these changes Mar 8, 2022

View reviewed changes

google-oss-prow bot added the lgtm label Mar 8, 2022

roberthbailey merged commit 3a91c0c into googleforgames:main Mar 8, 2022

roberthbailey mentioned this pull request Mar 22, 2022

Add a multi-cluster allocation example solution to leverage GCP resources to connect to multiple Agones clusters #2495

Closed

SaitejaTamma added this to the 1.22.0 milestone Mar 22, 2022

SaitejaTamma added the kind/feature New features for Agones label Mar 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Allocation Endpoint GCP solution for multi-cluster allocation to Agones examples #2499

Add Allocation Endpoint GCP solution for multi-cluster allocation to Agones examples #2499

pooneh-m commented Feb 28, 2022 •

edited

Loading

agones-bot commented Feb 28, 2022

markmandel commented Feb 28, 2022

roberthbailey left a comment

agones-bot commented Feb 28, 2022

ilkercelikyilmaz left a comment

pooneh-m left a comment

pooneh-m Mar 1, 2022

pooneh-m Mar 1, 2022

agones-bot commented Mar 1, 2022

markmandel commented Mar 1, 2022

pooneh-m commented Mar 2, 2022

agones-bot commented Mar 2, 2022

agones-bot commented Mar 2, 2022

roberthbailey left a comment

agones-bot commented Mar 6, 2022

roberthbailey left a comment

markmandel commented Mar 7, 2022 •

edited by roberthbailey

Loading

agones-bot commented Mar 8, 2022

agones-bot commented Mar 8, 2022

roberthbailey left a comment

google-oss-prow bot commented Mar 8, 2022

google-oss-prow bot commented Mar 8, 2022

agones-bot commented Mar 8, 2022

agones-bot commented Mar 8, 2022

Add Allocation Endpoint GCP solution for multi-cluster allocation to Agones examples #2499

Add Allocation Endpoint GCP solution for multi-cluster allocation to Agones examples #2499

Conversation

pooneh-m commented Feb 28, 2022 • edited Loading

agones-bot commented Feb 28, 2022

markmandel commented Feb 28, 2022

roberthbailey left a comment

Choose a reason for hiding this comment

agones-bot commented Feb 28, 2022

ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

pooneh-m left a comment

Choose a reason for hiding this comment

pooneh-m Mar 1, 2022

Choose a reason for hiding this comment

pooneh-m Mar 1, 2022

Choose a reason for hiding this comment

agones-bot commented Mar 1, 2022

markmandel commented Mar 1, 2022

pooneh-m commented Mar 2, 2022

agones-bot commented Mar 2, 2022

agones-bot commented Mar 2, 2022

roberthbailey left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 6, 2022

roberthbailey left a comment

Choose a reason for hiding this comment

markmandel commented Mar 7, 2022 • edited by roberthbailey Loading

agones-bot commented Mar 8, 2022

agones-bot commented Mar 8, 2022

roberthbailey left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Mar 8, 2022

google-oss-prow bot commented Mar 8, 2022

agones-bot commented Mar 8, 2022

agones-bot commented Mar 8, 2022

pooneh-m commented Feb 28, 2022 •

edited

Loading

markmandel commented Mar 7, 2022 •

edited by roberthbailey

Loading