Update the simple game server to move itself back to the Ready state after allocation #2409

roberthbailey · 2021-12-22T07:28:12Z

This allows us to test the "Reusing Allocated GameServers" integration pattern.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2021-12-22T07:57:57Z

Build Succeeded 👏

Build Id: 2f977b1a-96bc-4c3a-a3d1-ba1d5075c734

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.20.0-9d4796d
image: gcr.io/agones-images/agones-ping:1.20.0-9d4796d
Linux C++ SDK (build): agonessdk-1.20.0-9d4796d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.20.0-9d4796d.zip

A preview of the website (the last 30 builds are retained):

https://9d4796d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2409/head:pr_2409 && git checkout pr_2409
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.20.0-9d4796d

agones-bot · 2021-12-22T08:23:22Z

Build Failed 😱

Build Id: 5e0213ef-f097-4ec4-8782-4aea4d693b7a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-12-22T08:39:11Z

Build Failed 😱

Build Id: aa033046-3cc4-41b2-9d54-4b62171f7d51

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-12-22T23:42:26Z

Flake in e2e-feature-gates:

--- FAIL: TestAutoscalerStressCreate (313.73s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:355
        	            				fleetautoscaler_test.go:363
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAutoscalerStressCreate
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-gt2xm
...
--- FAIL: TestFleetAutoscalerTLSWebhook (316.14s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:709
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFleetAutoscalerTLSWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-6jspb
FAIL

agones-bot · 2021-12-23T00:07:32Z

Build Failed 😱

Build Id: 1176e9ca-f667-418e-a71a-3c86f272d726

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-12-23T01:38:17Z

Flake in e2e-stable:

--- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (347.23s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				gameserverallocation_test.go:544
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestGameServerAllocationDuringMultipleAllocationClients
        	Messages:   	error waiting for fleet condition on fleet: preferred-9k64r

agones-bot · 2021-12-23T02:03:20Z

Build Failed 😱

Build Id: 5a91fcbd-669b-4185-8291-60d25a9b2f3e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-12-23T06:20:54Z

Another flake in e2e-feature-gates:

--- FAIL: TestFleetAutoscalerTLSWebhook (313.26s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:709
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFleetAutoscalerTLSWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-c4bw7
FAIL

agones-bot · 2021-12-23T06:42:32Z

Build Failed 😱

Build Id: 5a9058fc-bdec-4c42-8f8e-dcecf03b31a0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-12-23T07:02:52Z

Build Failed 😱

Build Id: 5498aaa8-daf2-4a15-9fb7-b28d00770a5b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-prow · 2021-12-23T08:29:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cindy52, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2021-12-23T10:21:35Z

Build Failed 😱

Build Id: fdbaeb13-d61e-47d4-80b9-2e1ce18d324d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

after allocation. This allows us to test the "Reusing Allocated GameServers" integration pattern.

google-oss-prow · 2021-12-23T11:20:58Z

New changes are detected. LGTM label has been removed.

roberthbailey · 2021-12-23T11:25:20Z

I've been getting a weird error in the make test target:

/usr/share/dotnet/sdk/2.2.402/NuGet.targets(123,5): error : '1.20.0-0392579' is not a valid version string. [/go/src/agones.dev/agones/sdks/csharp/test/csharp-sdk-test.csproj]
/usr/share/dotnet/sdk/2.2.402/NuGet.targets(123,5): error : Parameter name: value [/go/src/agones.dev/agones/sdks/csharp/test/csharp-sdk-test.csproj]
make[1]: *** [includes/sdk.mk:88: run-sdk-command] Error 1
make: *** [includes/sdk.mk:84: run-sdk-command-csharp] Error 2

Microsoft's documentation says that the suffix is an optional string and that it should follow the semantic versioning convention. According to https://semver.org/spec/v1.0.0.html#spec-item-4

A pre-release version number MAY be denoted by appending an arbitrary string immediately following the patch version and a dash. The string MUST be comprised of only alphanumerics plus dash [0-9A-Za-z-].

The suffix here does follow that convention (0392579) but is being rejected. I reproduced locally on this branch and found that on other branches I wasn't seeing this error (nor did I see it on earlier commits here where I was getting flaky e2e errors but not csharp errors).

My guess is that because the string starts with a 0 it's being interpreted in a way that nuget doesn't like (maybe as a hex number instead of as a string). I've made a tiny change to the README file so that git will produce a different hash for this branch so that the csharp tests will pass.

agones-bot · 2021-12-23T11:54:29Z

Build Failed 😱

Build Id: 27960436-db61-482e-90e2-60f2052d0d24

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-12-23T11:58:58Z

Back to seeing the test flakes in e2e-feature-gates:

    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:709
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFleetAutoscalerTLSWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-dsfck

But this means that the csharp sdk code is now happy (for some unknown reason).

agones-bot · 2021-12-23T12:28:37Z

Build Succeeded 👏

Build Id: bcf853dd-a771-4e70-a4ae-19ef9614c119

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.20.0-35b967b
image: gcr.io/agones-images/agones-ping:1.20.0-35b967b
Linux C++ SDK (build): agonessdk-1.20.0-35b967b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.20.0-35b967b.zip

A preview of the website (the last 30 builds are retained):

https://35b967b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2409/head:pr_2409 && git checkout pr_2409
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.20.0-35b967b

examples/simple-game-server/README.md

ilkercelikyilmaz

LGTM

roberthbailey added the kind/feature New features for Agones label Dec 22, 2021

google-oss-prow bot added the size/M label Dec 22, 2021

google-oss-prow bot requested review from EricFortin and markmandel December 22, 2021 07:28

google-oss-prow bot added the approved label Dec 22, 2021

roberthbailey force-pushed the simple-game-server-reusing-game-servers branch from 9d4796d to 5d3cff3 Compare December 22, 2021 07:52

roberthbailey force-pushed the simple-game-server-reusing-game-servers branch from 5d3cff3 to 6052fab Compare December 22, 2021 08:14

roberthbailey mentioned this pull request Dec 22, 2021

Golang SDK callbacks for WatchGameServer are called synchronously #2410

Closed

roberthbailey assigned cindy52 Dec 23, 2021

roberthbailey force-pushed the simple-game-server-reusing-game-servers branch from 6052fab to 0392579 Compare December 23, 2021 06:49

cindy52 approved these changes Dec 23, 2021

View reviewed changes

google-oss-prow bot added the lgtm label Dec 23, 2021

Update the simple game server to move itself back to the Ready state

35b967b

after allocation. This allows us to test the "Reusing Allocated GameServers" integration pattern.

roberthbailey force-pushed the simple-game-server-reusing-game-servers branch from 0392579 to 35b967b Compare December 23, 2021 11:20

google-oss-prow bot removed the lgtm label Dec 23, 2021

roberthbailey merged commit f27f15e into googleforgames:main Dec 23, 2021

SaitejaTamma added this to the 1.20.0 milestone Jan 4, 2022

ilkercelikyilmaz reviewed Jan 14, 2022

View reviewed changes

examples/simple-game-server/README.md Show resolved Hide resolved

ilkercelikyilmaz reviewed Jan 14, 2022

View reviewed changes

roberthbailey mentioned this pull request Jan 20, 2022

Get the initial game server state before marking the simple game server ready #2440

Merged

roberthbailey deleted the simple-game-server-reusing-game-servers branch March 28, 2022 18:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the simple game server to move itself back to the Ready state after allocation #2409

Update the simple game server to move itself back to the Ready state after allocation #2409

roberthbailey commented Dec 22, 2021

agones-bot commented Dec 22, 2021

agones-bot commented Dec 22, 2021

agones-bot commented Dec 22, 2021

roberthbailey commented Dec 22, 2021

agones-bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

agones-bot commented Dec 23, 2021

google-oss-prow bot commented Dec 23, 2021

agones-bot commented Dec 23, 2021

google-oss-prow bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

ilkercelikyilmaz left a comment

Update the simple game server to move itself back to the Ready state after allocation #2409

Update the simple game server to move itself back to the Ready state after allocation #2409

Conversation

roberthbailey commented Dec 22, 2021

agones-bot commented Dec 22, 2021

agones-bot commented Dec 22, 2021

agones-bot commented Dec 22, 2021

roberthbailey commented Dec 22, 2021

agones-bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

agones-bot commented Dec 23, 2021

google-oss-prow bot commented Dec 23, 2021

agones-bot commented Dec 23, 2021

google-oss-prow bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

roberthbailey commented Dec 23, 2021

agones-bot commented Dec 23, 2021

ilkercelikyilmaz left a comment

Choose a reason for hiding this comment