Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to simple-game-server to shutdown after a specified number of seconds #2407

Merged

Conversation

roberthbailey
Copy link
Member

This flag will eventually replace the similar flag that specifies
the time in minutes to give a finer granularity for testing.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

number of seconds.

This flag will eventually replace the similar flag that specifies
the time in minutes to give a finer granularity for testing.
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cindy52, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2d12a54e-3c31-4e59-8349-5cd5c0d60ca1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2407/head:pr_2407 && git checkout pr_2407
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.20.0-d9479c6

@roberthbailey roberthbailey merged commit f7609c1 into googleforgames:main Dec 21, 2021
@SaitejaTamma SaitejaTamma added this to the 1.20.0 milestone Jan 4, 2022
@roberthbailey roberthbailey deleted the automaticShutdownDelaySec branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants