Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better e2e udp send errors #2349

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Better e2e udp send errors #2349

merged 1 commit into from
Oct 29, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Returning more descriptive error messages on SendUDP so we can see what is happening there a bit better.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Also cleaned up a small thing left behind in the gameserver e2e tests.

@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Oct 29, 2021
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@markmandel
Better e2e udp send errors
cfdb2bd 
Returning more descriptive error messages on `SendUDP` so we can see
what is happening there a bit better.

Also cleaned up a small thing left behind in the gameserver e2e tests.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 32014cef-0b81-4da6-b9c0-f784712ab839

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Well it gives a better error message:

fleet_test.go:1337: Could not message GameServer: could not read response from the GameServer: read udp 192.168.10.4:36834->35.247.94.25:7983: i/o timeout

Now to work out why it isn't responding sometimes. Maybe on message timeout we dump GameServer info as well.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5fe18650-f42b-40ad-9a21-95dc4c8ba6a4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2349/head:pr_2349 && git checkout pr_2349
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-cfdb2bd

@markmandel markmandel merged commit 86be4de into googleforgames:main Oct 29, 2021
@markmandel markmandel deleted the flaky/udp-retry branch October 29, 2021 18:44
@roberthbailey roberthbailey added this to the 1.19.0 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/bug These are bugs. lgtm size/S
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey