Upgrade `terraform-aws-eks` to `v17.22.0` #2344

vladbat00 · 2021-10-28T09:29:03Z

What type of PR is this?
/kind bug

What this PR does / Why we need it:

Without this change, validation of the EKS example fails on Terraform v1.0.9 with the following error:

╷
│ Error: Error in function call
│
│   on .terraform/modules/eks_cluster.eks/outputs.tf line 3, in output "cluster_id":
│    3:   value       = element(concat(aws_eks_cluster.this.*.id, list("")), 0)
│
│ Call to function "list" failed: the "list" function was deprecated in Terraform v0.12 and is no longer available; use tolist([ ... ]) syntax to write a literal list.
╵

(there are 4 more instances of it)

I hope this upgrade doesn't introduce any breaking changes. So far, I've simply got the example to validate successfully.

google-cla · 2021-10-28T09:29:09Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

vladbat00 · 2021-10-28T09:30:40Z

@googlebot I signed it!

agones-bot · 2021-10-28T09:59:26Z

Build Failed 😱

Build Id: 3b0f8791-b371-42a1-94b4-4dd04a8295a8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-robot · 2021-10-28T19:19:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mvlabat, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2021-10-29T16:23:56Z

New changes are detected. LGTM label has been removed.

agones-bot · 2021-10-29T16:49:18Z

Build Failed 😱

Build Id: 71ceb303-70ed-4931-b4d0-b991ff3cbee3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-29T16:53:51Z

--- FAIL: TestPlayerConnectAndDisconnect (97.96s)
    gameserver_test.go:1069: Could not message GameServer: read udp 192.168.10.2:36309->35.197.104.56:7379: i/o timeout

agones-bot · 2021-10-29T17:19:56Z

Build Failed 😱

Build Id: 755bcb93-5ea4-4902-be43-6d4cf579075b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-29T17:45:50Z

--- FAIL: TestFleetAutoscalerTLSWebhook (332.26s)
    framework.go:757: 
        	Error Trace:	framework.go:757
        	            				framework.go:315
        	            				framework.go:285
        	            				fleetautoscaler_test.go:708
        	Error:      	Received unexpected error:
        	            	won't be able to find any events of namespace 'default' in namespace '1635527383'
        	Test:       	TestFleetAutoscalerTLSWebhook

agones-bot · 2021-10-29T18:18:18Z

Build Failed 😱

Build Id: 32314eb1-6b81-41ba-9518-a102cae15646

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

vladbat00 · 2021-10-29T22:12:42Z

@roberthbailey do you believe these fails are caused by my changes? Is there anything I can help with?

markmandel · 2021-10-29T22:45:52Z

@roberthbailey do you believe these fails are caused by my changes? Is there anything I can help with?

Not your fault. We recently upgraded everything to kubernetes 1.21 and for some reason it's causing all kinds of flakes in our tests. We're digging through it to find the root cause.

agones-bot · 2021-10-30T04:55:53Z

Build Failed 😱

Build Id: 0a96fad3-4b69-42ed-a956-c7a8c7da984a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-30T05:04:29Z

--- FAIL: TestGameServerReadyAllocateReady (17.79s)
    gameserver_test.go:510: 
        	Error Trace:	gameserver_test.go:510
        	Error:      	Received unexpected error:
        	            	read udp 192.168.10.6:33624->35.227.187.145:7069: read: connection refused
        	            	could not read response from the GameServer
        	            	agones.dev/agones/test/e2e/framework.SendUDP
        	            		/go/src/agones.dev/agones/test/e2e/framework/framework.go:530
        	            	agones.dev/agones/test/e2e/framework.SendGameServerUDPToPort
        	            		/go/src/agones.dev/agones/test/e2e/framework/framework.go:496
        	            	agones.dev/agones/test/e2e/framework.SendGameServerUDP
        	            		/go/src/agones.dev/agones/test/e2e/framework/framework.go:477
        	            	agones.dev/agones/test/e2e.TestGameServerReadyAllocateReady
        	            		/go/src/agones.dev/agones/test/e2e/gameserver_test.go:509
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1581
        	Test:       	TestGameServerReadyAllocateReady
        	Messages:   	Could not message GameServer

agones-bot · 2021-10-30T05:55:49Z

Build Failed 😱

Build Id: f004ae43-8158-4ca2-9f5c-f92c81ebe150

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-30T06:06:55Z

--- FAIL: TestGameServerReserve (47.60s)
    gameserver_test.go:626: 
        	Error Trace:	gameserver_test.go:626
        	Error:      	Could not message GameServer
        	Test:       	TestGameServerReserve
        	Messages:   	could not read response from the GameServer: read udp 192.168.10.7:41539->35.227.187.145:7924: i/o timeout

agones-bot · 2021-10-30T06:36:20Z

Build Succeeded 👏

Build Id: 2386a2fa-e2fc-4d3a-ad67-4b3f7071f1bb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.19.0-df0a2fd
image: gcr.io/agones-images/agones-ping:1.19.0-df0a2fd
Linux C++ SDK (build): agonessdk-1.19.0-df0a2fd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.19.0-df0a2fd.zip

A preview of the website (the last 30 builds are retained):

https://df0a2fd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2344/head:pr_2344 && git checkout pr_2344
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-df0a2fd

Upgrade terraform-aws-eks to v17.22.0

651f1f6

google-cla bot added the cla: no label Oct 28, 2021

google-oss-robot requested review from markmandel and pooneh-m October 28, 2021 09:29

google-oss-robot added the size/XS label Oct 28, 2021

google-cla bot added cla: yes and removed cla: no labels Oct 28, 2021

roberthbailey approved these changes Oct 28, 2021

View reviewed changes

google-oss-robot assigned roberthbailey Oct 28, 2021

google-oss-robot added the lgtm label Oct 28, 2021

google-oss-robot added the approved label Oct 28, 2021

Merge branch 'main' into patch-2

fe67d80

google-oss-robot removed the lgtm label Oct 29, 2021

Merge branch 'main' into patch-2

df0a2fd

roberthbailey merged commit ee90c38 into googleforgames:main Oct 30, 2021

vladbat00 deleted the patch-2 branch October 30, 2021 08:32

roberthbailey added this to the 1.19.0 milestone Nov 1, 2021

SaitejaTamma added the kind/bug These are bugs. label Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade `terraform-aws-eks` to `v17.22.0` #2344

Upgrade `terraform-aws-eks` to `v17.22.0` #2344

vladbat00 commented Oct 28, 2021

google-cla bot commented Oct 28, 2021

vladbat00 commented Oct 28, 2021

agones-bot commented Oct 28, 2021

google-oss-robot commented Oct 28, 2021

google-oss-robot commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

vladbat00 commented Oct 29, 2021

markmandel commented Oct 29, 2021

agones-bot commented Oct 30, 2021

roberthbailey commented Oct 30, 2021

agones-bot commented Oct 30, 2021

roberthbailey commented Oct 30, 2021

agones-bot commented Oct 30, 2021

Upgrade terraform-aws-eks to v17.22.0 #2344

Upgrade terraform-aws-eks to v17.22.0 #2344

Conversation

vladbat00 commented Oct 28, 2021

google-cla bot commented Oct 28, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

vladbat00 commented Oct 28, 2021

agones-bot commented Oct 28, 2021

google-oss-robot commented Oct 28, 2021

google-oss-robot commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

vladbat00 commented Oct 29, 2021

markmandel commented Oct 29, 2021

agones-bot commented Oct 30, 2021

roberthbailey commented Oct 30, 2021

agones-bot commented Oct 30, 2021

roberthbailey commented Oct 30, 2021

agones-bot commented Oct 30, 2021

Upgrade `terraform-aws-eks` to `v17.22.0` #2344

Upgrade `terraform-aws-eks` to `v17.22.0` #2344