Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated aks.md #2337

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Updated aks.md #2337

merged 4 commits into from
Oct 27, 2021

Conversation

AmieDD
Copy link
Contributor

@AmieDD AmieDD commented Oct 25, 2021

Updated Azure Portal link, and clarification of AKS abbreviation.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:
Azure portal link, and abbreviation clarification for AKS.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

Updated Azure Portal link, and clarification of AKS abbreviation.
@google-cla
Copy link

google-cla bot commented Oct 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AmieDD
Copy link
Contributor Author

AmieDD commented Oct 25, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 25, 2021
@AmieDD
Copy link
Contributor Author

AmieDD commented Oct 25, 2021

/assign @dzlier-gcp

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a6840c27-afc2-44e4-b723-c9bbfc186bff

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c1539231-7c56-4bdf-bfa1-897d9a1b0332

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Blerg,

--- FAIL: TestUnhealthyGameServersWithoutFreePorts (445.70s)
    gameserver_test.go:215: 
        	Error Trace:	gameserver_test.go:215
        	Error:      	Expected nil, but got: &errors.errorString{s:"waiting for {game-server [{udp-port Static <nil> 7654 5555 UDP}] {false 0 0 0}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []} {[] [] [{game-server gcr.io/agones-images/simple-game-server:0.4 [] []  [] [] [] {map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}] map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}]} [] [] nil nil nil nil   IfNotPresent nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil>}} <nil>} GameServer instance readiness timed out (): waiting for GameServer to be Ready 1635265936/game-serverdtwtz: timed out waiting for the condition"}
        	Test:       	TestUnhealthyGameServersWithoutFreePorts
FAIL

is being very flaky.

@roberthbailey
Copy link
Member

@markmandel - Have you filed a flaky test issue for TestUnhealthyGameServersWithoutFreePorts yet?

@markmandel
Copy link
Member

Have now:
#2339

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8ff63720-2461-438e-a179-5851ccde4d11

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AmieDD, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c307a1d7-ad6b-4b97-adc3-f4e69c526f31

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

--- FAIL: TestUnhealthyGameServersWithoutFreePorts (404.03s)
    gameserver_test.go:215: 
        	Error Trace:	gameserver_test.go:215
        	Error:      	Expected nil, but got: &errors.errorString{s:"waiting for {game-server [{udp-port Static <nil> 7654 5555 UDP}] {false 0 0 0}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []} {[] [] [{game-server gcr.io/agones-images/simple-game-server:0.4 [] []  [] [] [] {map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}] map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}]} [] [] nil nil nil nil   IfNotPresent nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil>}} <nil>} GameServer instance readiness timed out (): waiting for GameServer to be Ready 1635364127/game-serverrpzrx: timed out waiting for the condition"}
        	Test:       	TestUnhealthyGameServersWithoutFreePorts
FAIL

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f1a61a37-5532-4db2-a82a-a3f549e24ba1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1efbdb15-d2d1-421b-ab56-d693006c40eb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2337/head:pr_2337 && git checkout pr_2337
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-de9b840

@roberthbailey roberthbailey merged commit fc6e787 into googleforgames:main Oct 27, 2021
@AmieDD AmieDD deleted the patch-1 branch October 27, 2021 23:32
@roberthbailey roberthbailey added this to the 1.19.0 milestone Nov 1, 2021
@SaitejaTamma SaitejaTamma added the kind/bug These are bugs. label Nov 16, 2021
@roberthbailey roberthbailey added kind/documentation Documentation for Agones and removed kind/bug These are bugs. labels Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants