Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to fix CI #2313

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Looks like a new release of Tower breaks on older versions of Rust, so I upgraded our version of Rust, and now things should be moving again!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Looks like a new release of Tower breaks on older versions of Rust, so I
upgraded our version of Rust, and now things should be moving again!
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Oct 14, 2021
@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 75863717-19c1-4ff9-96e7-4059850c2619

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2313/head:pr_2313 && git checkout pr_2313
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-c633992

@roberthbailey roberthbailey merged commit 1bb61a7 into googleforgames:main Oct 15, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel deleted the ci/rust-update branch October 19, 2021 21:04
@roberthbailey roberthbailey added this to the 1.19.0 milestone Nov 1, 2021
@SaitejaTamma SaitejaTamma added the kind/bug These are bugs. label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants