Upgraded Terraform to >=1.0 #2308
Conversation
zaratsian
changed the title
|
Build Failed 😱 Build Id: 41890df6-6c6a-48c6-a063-c2f0a8f3202f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
I should take this for an actual spin, but I'm also figuring we should update: agones/build/build-image/Dockerfile Line 108 in c74d6f3 To update the local terraform used on our build tools as well. |
|
Build Failed 😱 Build Id: b827105d-81c0-4008-9cc4-081722decdbe To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
I'm not sure how far behind main you are, but the build failed on the link checker to a couple of sites where we have disabled link checking (because tests weren't passing). Trying fetching and rebasing onto upstream/main to see if that helps the tests pass. |
|
Build Failed 😱 Build Id: bf95321b-bdce-4cad-b4f9-3e42a03afc80 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
@markmandel, good call on updating the build-image. I missed that Terraform mention initially. It's in there now, and will install Terraform 1.0.8. @roberthbailey, thanks for checking out the failed tests. I checked it out and was behind main. I updated the fork and will rebase now. The latest test seems to past all but step 21:e2e-feature-gates (fleetautoscaler_test.go:88: error waiting for fleet condition on fleet simple-fleet-kmm8f). |
|
Build Succeeded 👏 Build Id: d23310c5-5c47-4730-adfc-f500a300008c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Can you please update https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Installation/Terraform/_index.md to change the supported version of Terraform to 1.0.0?
build/terraform/e2e/module.tf
Outdated
| provider "google" { | ||
| version = "~> 2.10" | ||
| terraform { | ||
| required_version = ">= 1.0.0" |
There was a problem hiding this comment.
nit: This line has extra whitespace at the end.
build/terraform/gke/module.tf
Outdated
| // terraform apply -var project="<YOUR_GCP_ProjectID>" [-var agones_version="1.17.0"] | ||
|
|
||
| terraform { | ||
| required_version = ">= 1.0.0" |
There was a problem hiding this comment.
nit: This line has extra whitespace at the end.
build/terraform/prow/module.tf
Outdated
| provider "google" { | ||
| version = "~> 2.10" | ||
| terraform { | ||
| required_version = ">= 1.0.0" |
There was a problem hiding this comment.
nit: This line has extra whitespace at the end.
| // terraform apply [-var agones_version="1.17.0"] | ||
|
|
||
| terraform { | ||
| required_version = ">= 1.0.0" |
There was a problem hiding this comment.
nit: This line has extra whitespace at the end.
| // terraform apply -var project="<YOUR_GCP_ProjectID>" [-var agones_version="1.17.0"] | ||
|
|
||
| terraform { | ||
| required_version = ">= 1.0.0" |
There was a problem hiding this comment.
nit: This line has extra whitespace at the end.
install/terraform/modules/eks/eks.tf
Outdated
| @@ -14,11 +14,16 @@ | |||
|
|
|||
|
|
|||
| terraform { | |||
| required_version = ">= 0.12.6" | |||
| required_version = ">= 1.0.0" | |||
There was a problem hiding this comment.
nit: This line has extra whitespace at the end.
|
Build Succeeded 👏 Build Id: 4c30bc84-2d94-422b-98ca-a37dfff386b4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Thanks for the review @roberthbailey! I've cleaned up the whitespaces and updated/tested the site doc as well. Please let me know if you see any additional changes that are required. |
|
Build Succeeded 👏 Build Id: e8cd88b2-1c95-4e72-a42e-2d15c56b164f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey, zaratsian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: 30ff1ef2-7eef-49c7-8f0b-036ffe648238 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What this PR does / Why we need it:
Upgrades Terraform deployment scripts to support version >= 1.0.0 across build, install, and example directories.
Which issue(s) this PR fixes:
#2142
Special notes for your reviewer:
I scanned the existing repo and believe that I've accounted for all Terraform scripts. Please let me know if you see any other terraform files or dependencies that also need to be updated as part of this PR.