-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some extra emphasis on the breaking change in the helm parameters related to the allocator service #2305
Add some extra emphasis on the breaking change in the helm parameters related to the allocator service #2305
Conversation
@@ -77,6 +77,13 @@ helm upgrade --install --wait \ | |||
... | |||
``` | |||
|
|||
{{< alert title="Warning" color="warning">}} The parameter used to automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this note is needed as the document is versioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true, and that's why I didn't originally add it. However, I think that if someone is going to look at this section it might not be immediately obvious what changed (unless you diff the pages or have really good memory). It's there as an extra bit of a reminder, and in case you didn't carefully read the breaking change in the release notes.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pooneh-m, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related to the allocator service.
64254de
to
8b7f0fe
Compare
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 780efb01-2df7-4151-994a-5e1ff696b20a To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 189b447e-50bd-4a69-82af-168b0c7cc419 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind documentation
What this PR does / Why we need it: Make the release note for 1.18-rc clearer and add an extra warning to the allocator service page in case folks didn't read the release notes.
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: