Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some extra emphasis on the breaking change in the helm parameters related to the allocator service #2305

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it: Make the release note for 1.18-rc clearer and add an extra warning to the allocator service page in case folks didn't read the release notes.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@roberthbailey roberthbailey added the kind/documentation Documentation for Agones label Oct 11, 2021
@roberthbailey roberthbailey added this to the 1.18.0 milestone Oct 11, 2021
@google-cla google-cla bot added the cla: yes label Oct 11, 2021
@@ -77,6 +77,13 @@ helm upgrade --install --wait \
...
```

{{< alert title="Warning" color="warning">}} The parameter used to automatically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this note is needed as the document is versioned.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true, and that's why I didn't originally add it. However, I think that if someone is going to look at this section it might not be immediately obvious what changed (unless you diff the pages or have really good memory). It's there as an extra bit of a reminder, and in case you didn't carefully read the breaking change in the release notes.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 780efb01-2df7-4151-994a-5e1ff696b20a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 189b447e-50bd-4a69-82af-168b0c7cc419

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2305/head:pr_2305 && git checkout pr_2305
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-8b7f0fe

@roberthbailey roberthbailey merged commit 70d56ad into googleforgames:main Oct 12, 2021
@roberthbailey roberthbailey deleted the helm-changes-docs branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants