-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: High Density Integration Pattern #2270
Docs: High Density Integration Pattern #2270
Conversation
Build Failed 😱 Build Id: 3ca829cf-3029-4d79-ac9a-3262827ee67f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: d8f000e7-9cc4-423a-bd12-2900785545f9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
https://d23d739-dot-preview-dot-agones-images.appspot.com/site/docs/integration-patterns/high-density-gameservers/ if people are looking for the preview |
d23d739
to
2ad4e07
Compare
Build Succeeded 👏 Build Id: 0ac661f1-d74f-4629-893d-ec62911991e4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
site/content/en/docs/Integration Patterns/high-density-gameservers.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/Integration Patterns/high-density-gameservers.md
Outdated
Show resolved
Hide resolved
2ad4e07
to
f8e90eb
Compare
Build Succeeded 👏 Build Id: ee262ef0-cb48-4f38-9991-f34e6fecabd9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Documentation explaining how to use the new advanced allocation features to run multiple concurrent game sessions in a single `GameServer` instance. Closes googleforgames#1239
f8e90eb
to
c1a2130
Compare
Updated! I think this should be good to go now! |
Build Succeeded 👏 Build Id: 2ff5200b-c3b5-4a18-89e0-da21a1c875d1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a minor typo and have one last grammatical suggestion.
systems, since it works around the common Kubernetes and/or Agones container lifecycle. | ||
|
||
Utilising the new allocation `gameServerState` filter as well as the existing ability to edit the | ||
`GameServer` Labels at both [allocation time]({{% ref "/docs/Reference/gameserverallocation.md" %}}), and from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Labels should be lowercase as it is in the middle of a sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
end alt | ||
note right | ||
If the <i>GameServer</i> can accept | ||
more concurrent sessions, reset the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: reset the label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
c1a2130
to
1a402b4
Compare
1a402b4
to
29dd542
Compare
Build Succeeded 👏 Build Id: 4237d65d-33f2-40bd-a5d3-b1c93e681c23 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 3f3517b4-be53-4995-b999-d9155f4c6159 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Documentation explaining how to use the new advanced allocation features to run multiple concurrent game sessions in a single
GameServer
instance.Which issue(s) this PR fixes:
Closes #1239
Special notes for your reviewer:
This is tricky to explain, because it is a little complicated. All feedback appreciated to try and explain this concept!
If you have thoughts on if there are improvements / better ways to explain, please add them to this PR 👍🏻