Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "Integration Patterns" section in docs #2215

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

This sets us up to write the series of guides for Game Server Allocation advanced filtering (#1239), as well as adding
extra guides for integrations such as:

  • Websocket servers
  • Reusing GameServers
  • Canary Testing

And I'm sure more will show up!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 689b4eda-1cbf-42c8-907d-635c8bd07010

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0ec0b455-47dc-4f7f-b75d-278fef97606e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Tracking Failure I need to fix:

Html Test: Attempt 1
htmltest started at 12:58:36 on /tmp/website
========================================================================
site/docs/integration-patterns/matchmaker-registration/index.html
  target does not exist --- site/docs/integration-patterns/matchmaker-registration/index.html --> ../../../../diagrams/gameserver-reserved.puml.png
========================================================================
✘✘✘ failed in 307.854464ms

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bb88761e-3527-498d-9de0-32626658e2ec

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2215/head:pr_2215 && git checkout pr_2215
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-88341a4

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sets us up to write the series of guides for
Game Server Allocation advanced filtering (googleforgames#1239), as well as adding
extra guides for integrations such as:

* Websocket servers
* Reusing GameServers
* Canary Testing

And I'm sure more will show up!
@markmandel markmandel force-pushed the docs/integration-patterns-1 branch from 88341a4 to bfaa167 Compare August 18, 2021 19:11
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 50a5ad07-ec5c-4833-a5cc-b6742af37549

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2215/head:pr_2215 && git checkout pr_2215
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-bfaa167

@roberthbailey roberthbailey merged commit a6de25c into googleforgames:main Aug 18, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel deleted the docs/integration-patterns-1 branch August 19, 2021 21:06
@roberthbailey roberthbailey added this to the 1.17.0 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants