Used array of FStringFormatArg to process FString::Format to fix erro… #2170

WilSimpson · 2021-07-03T22:13:05Z

…rs in BuildAgonesRequest

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2169

Special notes for your reviewer:

google-cla · 2021-07-03T22:13:08Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

WilSimpson · 2021-07-03T22:15:16Z

@googlebot I signed it!

google-cla · 2021-07-03T22:15:20Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-03T22:21:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

WilSimpson · 2021-07-03T22:22:39Z

@googlebot I fixed it.

google-cla · 2021-07-03T22:22:43Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

WilSimpson · 2021-07-03T22:28:35Z

I'm unable to update for my other personal email address used [email protected] since it has been used by someone else for their Google account so I cannot verify that one. I have however committed with my GitHub email so it all matches for one. /assign @pooneh-m

agones-bot · 2021-07-03T22:37:45Z

Build Succeeded 👏

Build Id: ec2bf119-ed2c-46f1-8e64-66883d688646

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-ea27510
image: gcr.io/agones-images/agones-ping:1.16.0-ea27510
Linux C++ SDK (build): agonessdk-1.16.0-ea27510-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-ea27510.zip

A preview of the website (the last 30 builds are retained):

https://ea27510-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2170/head:pr_2170 && git checkout pr_2170
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-ea27510

agones-bot · 2021-07-03T22:49:35Z

Build Succeeded 👏

Build Id: 7510b8dd-a61e-492d-b016-d0c4aa9f36e4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-badbde4
image: gcr.io/agones-images/agones-ping:1.16.0-badbde4
Linux C++ SDK (build): agonessdk-1.16.0-badbde4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-badbde4.zip

A preview of the website (the last 30 builds are retained):

https://badbde4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2170/head:pr_2170 && git checkout pr_2170
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-badbde4

WilSimpson · 2021-07-04T10:28:59Z

/assign @pooneh-m

roberthbailey · 2021-07-06T21:38:46Z

@WilSimpson - Thanks for the bug fix! Can you please sign the CLA?

roberthbailey · 2021-07-06T21:39:20Z

This look reasonable to me, but I'd like to get a quick review from @domgreen who has been helping maintain our unreal code.

/assign @domgreen

google-oss-robot · 2021-07-06T21:39:22Z

@roberthbailey: GitHub didn't allow me to assign the following users: domgreen.

Note that only googleforgames members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This look reasonable to me, but I'd like to get a quick review from @domgreen who has been helping maintain our unreal code.

/assign @domgreen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WilSimpson · 2021-07-07T04:18:54Z

@WilSimpson - Thanks for the bug fix! Can you please sign the CLA?

Long story short I can't for this fork due to issues with the original committing email. Worst case I can create a new fork and commit with a different email.

roberthbailey · 2021-07-07T05:13:56Z

Worst case I can create a new fork and commit with a different email.

We can't merge a change without the CLA being signed, so if that is the only way to appease the CLA, then it sounds like the best path forward.

googlebot · 2021-07-08T00:02:40Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

markmandel · 2021-07-08T00:07:09Z

Long story short I can't for this fork due to issues with the original committing email. Worst case I can create a new fork and commit with a different email.

If you rebase this PR down to a single commit authored with your @gmail.com address, and force push over the top, then the CLA bot should accept it without issue.

Also calling @highlyunavailable who has been doing lots of Unreal stuff as of late.

markmandel · 2021-07-08T16:51:01Z

Just a heads up - Release Candidate is next Tuesday, so if you would like this fix in the next release, that'll be the target to aim for 👍🏻

agones-bot · 2021-07-28T03:04:30Z

Build Succeeded 👏

Build Id: 145b8115-4483-4930-afe6-f3b6eec3093a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-8ead913
image: gcr.io/agones-images/agones-ping:1.17.0-8ead913
Linux C++ SDK (build): agonessdk-1.17.0-8ead913-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-8ead913.zip

A preview of the website (the last 30 builds are retained):

https://8ead913-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2170/head:pr_2170 && git checkout pr_2170
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-8ead913

google-cla · 2021-07-28T06:42:01Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

agones-bot · 2021-07-28T07:01:09Z

Build Failed 😱

Build Id: 3e5a88f3-d944-48db-8871-28927b4d2de2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

… code by creating two static methods.

google-cla · 2021-07-28T07:55:52Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

WilSimpson · 2021-07-28T08:04:44Z

I have updated the changes as requested by @highlyunavailable. Everything runs smoothly on UE5ea2. I did not test in 4.26, however I do not believe these changes should effect 4.26 as it follows their guidelines as well.

There were not issues with passing a single element, however I converted them all for completeness and to avoid future errors. Since there was so much repetitive code, I included a few static method helper functions. I believe the few cycles added by making the additional private static methods out weigh the readability for the repetitiveness. Let me know if you disagree.

agones-bot · 2021-07-28T08:22:12Z

Build Succeeded 👏

Build Id: 09cec38f-51dc-442d-be65-3739e232660b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-d1a81d9
image: gcr.io/agones-images/agones-ping:1.17.0-d1a81d9
Linux C++ SDK (build): agonessdk-1.17.0-d1a81d9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-d1a81d9.zip

A preview of the website (the last 30 builds are retained):

https://d1a81d9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2170/head:pr_2170 && git checkout pr_2170
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-d1a81d9

highlyunavailable

Looks fine to me. There may be some formatting nits but I can confirm it builds fine on 4.26.2 as well.

google-oss-robot · 2021-07-28T16:50:07Z

@highlyunavailable: changing LGTM is restricted to collaborators

In response to this:

Looks fine to me. There may be some formatting nits but I can confirm it builds fine on 4.26.2 as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

markmandel

Yay! Looks like we have a winner. Approving and merging!

google-oss-robot · 2021-07-28T18:46:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: highlyunavailable, markmandel, WilSimpson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2021-07-28T19:28:21Z

New changes are detected. LGTM label has been removed.

google-cla · 2021-07-28T19:28:26Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

agones-bot · 2021-07-28T20:03:40Z

Build Succeeded 👏

Build Id: 5e34d22e-8d85-4808-b6a0-c62722b3e732

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-f2ed4a6
image: gcr.io/agones-images/agones-ping:1.17.0-f2ed4a6
Linux C++ SDK (build): agonessdk-1.17.0-f2ed4a6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-f2ed4a6.zip

A preview of the website (the last 30 builds are retained):

https://f2ed4a6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2170/head:pr_2170 && git checkout pr_2170
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-f2ed4a6

google-cla · 2021-07-28T20:54:38Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

agones-bot · 2021-07-28T21:19:40Z

Build Succeeded 👏

Build Id: 8ceef899-bd68-403a-b5a2-74bea5527eba

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-f4967be
image: gcr.io/agones-images/agones-ping:1.17.0-f4967be
Linux C++ SDK (build): agonessdk-1.17.0-f4967be-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-f4967be.zip

A preview of the website (the last 30 builds are retained):

https://f4967be-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2170/head:pr_2170 && git checkout pr_2170
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-f4967be

google-cla bot added the cla: no label Jul 3, 2021

google-oss-robot added the size/XS label Jul 3, 2021

google-oss-robot requested review from aLekSer and EricFortin July 3, 2021 22:13

google-oss-robot assigned pooneh-m Jul 4, 2021

roberthbailey unassigned pooneh-m Jul 6, 2021

roberthbailey added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jul 13, 2021

google-oss-robot added size/L and removed size/XS labels Jul 14, 2021

WilSimpson closed this Jul 14, 2021

google-oss-robot added size/XS and removed size/L labels Jul 14, 2021

Merge branch 'googleforgames:main' into main

3cf96b3

WilSimpson added 2 commits July 28, 2021 02:55

Added changes as requested by @highlyunavailable. Reduced repeatative…

b7b0195

… code by creating two static methods.

Merge branch 'main' of https://github.com/WilSimpson/agones

d1a81d9

google-oss-robot added size/L and removed size/S labels Jul 28, 2021

highlyunavailable approved these changes Jul 28, 2021

View reviewed changes

markmandel approved these changes Jul 28, 2021

View reviewed changes

google-oss-robot assigned markmandel Jul 28, 2021

google-oss-robot added the lgtm label Jul 28, 2021

google-oss-robot added the approved label Jul 28, 2021

Merge branch 'main' into main

f2ed4a6

google-oss-robot removed the lgtm label Jul 28, 2021

Merge branch 'main' into main

f4967be

markmandel merged commit 8ca4929 into googleforgames:main Jul 28, 2021

markmandel added this to the 1.17.0 milestone Jul 28, 2021

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Jul 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Used array of FStringFormatArg to process FString::Format to fix erro… #2170

Used array of FStringFormatArg to process FString::Format to fix erro… #2170

WilSimpson commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

WilSimpson commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

WilSimpson commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

WilSimpson commented Jul 3, 2021

agones-bot commented Jul 3, 2021

agones-bot commented Jul 3, 2021

WilSimpson commented Jul 4, 2021

roberthbailey commented Jul 6, 2021

roberthbailey commented Jul 6, 2021

google-oss-robot commented Jul 6, 2021

WilSimpson commented Jul 7, 2021

roberthbailey commented Jul 7, 2021

googlebot commented Jul 8, 2021

markmandel commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

agones-bot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

WilSimpson commented Jul 28, 2021

agones-bot commented Jul 28, 2021

highlyunavailable left a comment

google-oss-robot commented Jul 28, 2021

markmandel left a comment

google-oss-robot commented Jul 28, 2021

google-oss-robot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

agones-bot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

agones-bot commented Jul 28, 2021

Used array of FStringFormatArg to process FString::Format to fix erro… #2170

Used array of FStringFormatArg to process FString::Format to fix erro… #2170

Conversation

WilSimpson commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

WilSimpson commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

WilSimpson commented Jul 3, 2021

google-cla bot commented Jul 3, 2021

WilSimpson commented Jul 3, 2021

agones-bot commented Jul 3, 2021

agones-bot commented Jul 3, 2021

WilSimpson commented Jul 4, 2021

roberthbailey commented Jul 6, 2021

roberthbailey commented Jul 6, 2021

google-oss-robot commented Jul 6, 2021

WilSimpson commented Jul 7, 2021

roberthbailey commented Jul 7, 2021

googlebot commented Jul 8, 2021

markmandel commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

agones-bot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

WilSimpson commented Jul 28, 2021

agones-bot commented Jul 28, 2021

highlyunavailable left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jul 28, 2021

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jul 28, 2021

google-oss-robot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

agones-bot commented Jul 28, 2021

google-cla bot commented Jul 28, 2021

agones-bot commented Jul 28, 2021