Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace grpcio with tonic #2112
Replace grpcio with tonic #2112
Changes from all commits
cc38079
5085d9b
1be03ed
2fedfac
4aa3db4
defc1ee
46a27e5
410f818
89d5ffd
ee05aef
410940d
c30a32c
dafdd74
82269bd
dec667d
fd38dda
d650d4b
905fdf5
b7a9eba
8b8f291
5df8948
776c861
3982b07
ed847f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces error-chain, which has seen declining usage in the rust ecosystem due to its fairly confusing and heavy approach to errors. That being said, the current error usage is extremely minimal, and we could get rid of thiserror as well and just use a custom error, since it's only used to wrap grpc status messages anyways since the sdk protocol doesn't have its own error types at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tonic is built on top of tokio which is (basically) the standard async runtime in the rust ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tonic is a rust native GRPC stack built on top of tokio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The common practice for tonic is to build the protocol buffers at build time, rather than checking the generated code into source, unlike the previous implementation. I can change this if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generates the Rust code for the protocol and places them in the
OUT
directory so that they can be included in the Rust code.